Re: [PATCH v3] x86/apicv: fix RTC periodic timer and apicv issue

["Tian, Kevin" <kevin.tian@intel.com>]

> From: Xuquan (Quan Xu) [mailto:xuquan8@huawei.com]
> Sent: Tuesday, December 20, 2016 9:12 PM
> 
> On December 20, 2016 1:37 PM, Tian, Kevin wrote:
> >> From: Xuquan (Quan Xu) [mailto:xuquan8@huawei.com]
> >> Sent: Friday, December 16, 2016 5:40 PM
> >I suppose you've verified this new version, but still would like get your
> >explicit confirmation - did you still see time accuracy issue in your side?
> >Have you tried other guest OS types other than Win7-32?
> >
> 
> Kevin, I have tested it again..
> 
> __without__ my patch, for win7-64, the wall clock time looks working fine..
> It seems the issue is only for win-32..

You need verify both w/ or w/o patch. It's not impossible that win7-64 has
no problem w/o this fix while sees some regression w/ the patch. This is
the purpose of the thorough test.

> 
> There is a easy way to reproduce:
> *pCPU should be v3 ..(my pCPU is """Intel(R) Xeon(R) CPU E5-2620 v3 @ 2.40GHz""")
> * more than 2 vCPUs for win32 guest.
> 
> Than run the following .bat in win32 guest:
> 
> :abcd
> echo 11111
> goto :abcd
> 
> 
> 
> 
> 
> Could Intel test team help me verify it?

Sure. Please work with Chao (CCed) offline on how you can cooperate to
have a complete test. Your help is still appreciated since you already have
the environment.

> 
> >> ---
> >>  xen/arch/x86/hvm/vmx/intr.c | 15 ++++++++++++---
> >>  1 file changed, 12 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c
> >> index 639a705..d7a5716 100644
> >> --- a/xen/arch/x86/hvm/vmx/intr.c
> >> +++ b/xen/arch/x86/hvm/vmx/intr.c
> >> -        if (pt_vector != -1)
> >> -            vmx_set_eoi_exit_bitmap(v, pt_vector);
> >> +        if ( pt_vector != -1 ) {
> >> +            if ( intack.vector > pt_vector )
> >> +                vmx_set_eoi_exit_bitmap(v, intack.vector);
> >> +            else
> >> +                vmx_set_eoi_exit_bitmap(v, pt_vector);
> >> +        }
> >
> >Above can be simplified as one line change:
> >	if ( pt_vector != -1 )
> >		vmx_set_eoi_exit_bitmap(v, intack.vector);
> >
> 
> I have verified this change.. it is working..
> Could I send out v4 with this changes?
> 

Please. I'll ack when you complete the test.

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel