From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A72C432C1 for ; Wed, 25 Sep 2019 07:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1A28217F4 for ; Wed, 25 Sep 2019 07:35:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437093AbfIYHf1 (ORCPT ); Wed, 25 Sep 2019 03:35:27 -0400 Received: from mga17.intel.com ([192.55.52.151]:53122 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390567AbfIYHf0 (ORCPT ); Wed, 25 Sep 2019 03:35:26 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 00:35:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,547,1559545200"; d="scan'208";a="188706169" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 25 Sep 2019 00:35:26 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 00:35:25 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 00:35:25 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 15:35:23 +0800 From: "Tian, Kevin" To: Peter Xu , Lu Baolu CC: Joerg Roedel , David Woodhouse , Alex Williamson , Yi Sun , "Raj, Ashok" , "kvm@vger.kernel.org" , "Kumar, Sanjay K" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "Sun, Yi Y" Subject: RE: [RFC PATCH 4/4] iommu/vt-d: Identify domains using first level page table Thread-Topic: [RFC PATCH 4/4] iommu/vt-d: Identify domains using first level page table Thread-Index: AQHVcgpG/pXRrE8O1EK3Luw5SA+K6qc7cLwAgACSPnA= Date: Wed, 25 Sep 2019 07:35:23 +0000 Message-ID: References: <20190923122454.9888-1-baolu.lu@linux.intel.com> <20190923122454.9888-5-baolu.lu@linux.intel.com> <20190925065006.GN28074@xz-x1> In-Reply-To: <20190925065006.GN28074@xz-x1> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWNjOWZjYmUtYzc2MS00MjE2LWJkYmYtYzU2YTdhNGI0OWMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSnozQ1pmXC9STHptMktYYkRDZzRUWjJ6MUk0bzJ2NWgzcXIxXC9pK05WeW1VRkg5K2FVUWJyVG9jcUQyenU4cmdWIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiBGcm9tOiBQZXRlciBYdSBbbWFpbHRvOnBldGVyeEByZWRoYXQuY29tXQ0KPiBTZW50OiBXZWRu ZXNkYXksIFNlcHRlbWJlciAyNSwgMjAxOSAyOjUwIFBNDQo+IA0KPiBPbiBNb24sIFNlcCAyMywg MjAxOSBhdCAwODoyNDo1NFBNICswODAwLCBMdSBCYW9sdSB3cm90ZToNCj4gPiArLyoNCj4gPiAr ICogQ2hlY2sgYW5kIHJldHVybiB3aGV0aGVyIGZpcnN0IGxldmVsIGlzIHVzZWQgYnkgZGVmYXVs dCBmb3INCj4gPiArICogRE1BIHRyYW5zbGF0aW9uLg0KPiA+ICsgKi8NCj4gPiArc3RhdGljIGJv b2wgZmlyc3RfbGV2ZWxfYnlfZGVmYXVsdCh2b2lkKQ0KPiA+ICt7DQo+ID4gKwlzdHJ1Y3QgZG1h cl9kcmhkX3VuaXQgKmRyaGQ7DQo+ID4gKwlzdHJ1Y3QgaW50ZWxfaW9tbXUgKmlvbW11Ow0KPiA+ ICsNCj4gPiArCXJjdV9yZWFkX2xvY2soKTsNCj4gPiArCWZvcl9lYWNoX2FjdGl2ZV9pb21tdShp b21tdSwgZHJoZCkNCj4gPiArCQlpZiAoIXNtX3N1cHBvcnRlZChpb21tdSkgfHwNCj4gPiArCQkg ICAgIWVjYXBfZmx0cyhpb21tdS0+ZWNhcCkgfHwNCj4gPiArCQkgICAgIWNhcF9jYWNoaW5nX21v ZGUoaW9tbXUtPmNhcCkpDQo+ID4gKwkJCXJldHVybiBmYWxzZTsNCj4gPiArCXJjdV9yZWFkX3Vu bG9jaygpOw0KPiA+ICsNCj4gPiArCXJldHVybiB0cnVlOw0KPiA+ICt9DQo+IA0KPiAiSWYgbm8g Y2FjaGluZyBtb2RlLCB0aGVuIHdlIHdpbGwgbm90IHVzZSAxc3QgbGV2ZWwuIg0KPiANCj4gSG1t LCBkb2VzIHRoZSB2SU9NTVUgbmVlZHMgdG8gc3VwcG9ydCBjYWNoaW5nLW1vZGUgaWYgd2l0aCB0 aGUNCj4gc29sdXRpb24geW91IHByb3Bvc2VkIGhlcmU/ICBDYWNoaW5nIG1vZGUgaXMgb25seSBu ZWNlc3NhcnkgZm9yDQo+IHNoYWRvd2luZyBBRkFJQ1QsIGFuZCBhZnRlciBhbGwgeW91J3JlIGdv aW5nIHRvIHVzZSBmdWxsLW5lc3RlZCwNCj4gdGhlbi4uLiB0aGVuIEkgd291bGQgdGhpbmsgaXQn cyBub3QgbmVlZGVkLiAgQW5kIGlmIHNvLCB3aXRoIHRoaXMNCj4gcGF0Y2ggMXN0IGxldmVsIHdp bGwgYmUgZGlzYWJsZWQuIFNvdW5kcyBsaWtlIGEgcGFyYWRveC4uLg0KPiANCj4gSSdtIHRoaW5r aW5nIHdoYXQgd291bGQgYmUgdGhlIGJpZyBwaWN0dXJlIGZvciB0aGlzIHRvIHdvcmsgbm93OiBG b3INCj4gdGhlIHZJT01NVSwgaW5zdGVhZCBvZiBleHBvc2luZyB0aGUgY2FjaGluZy1tb2RlLCBJ J20gdGhpbmtpbmcgbWF5YmUNCj4gd2Ugc2hvdWxkIGV4cG9zZSBpdCB3aXRoIGVjYXAuRkxUUz0x IHdoaWxlIHdlIGNhbiBrZWVwIGVjYXAuU0xUUz0wDQo+IHRoZW4gaXQncyBuYXR1cmFsIHRoYXQg d2UgY2FuIG9ubHkgdXNlIDFzdCBsZXZlbCB0cmFuc2xhdGlvbiBpbiB0aGUNCj4gZ3Vlc3QgZm9y IGFsbCB0aGUgZG9tYWlucyAoYW5kIEkgYXNzdW1lIHN1Y2ggYW4gZWNhcCB2YWx1ZSBzaG91bGQN Cj4gbmV2ZXIgaGFwcGVuIG9uIHJlYWwgaGFyZHdhcmUsIGFtIEkgcmlnaHQ/KS4NCj4gDQoNCnll cywgdGhhdCdzIGFsc28gdGhlIHBpY3R1cmUgaW4gbXkgbWluZC4gOi0pDQoNClRoYW5rcw0KS2V2 aW4NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FD6CC432C1 for ; Wed, 25 Sep 2019 07:35:36 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F643217F4 for ; Wed, 25 Sep 2019 07:35:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F643217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 678EABA9; Wed, 25 Sep 2019 07:35:36 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 54663B59 for ; Wed, 25 Sep 2019 07:35:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 54B608A0 for ; Wed, 25 Sep 2019 07:35:26 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 00:35:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,547,1559545200"; d="scan'208";a="188706169" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 25 Sep 2019 00:35:26 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 00:35:25 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 00:35:25 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 15:35:23 +0800 From: "Tian, Kevin" To: Peter Xu , Lu Baolu Subject: RE: [RFC PATCH 4/4] iommu/vt-d: Identify domains using first level page table Thread-Topic: [RFC PATCH 4/4] iommu/vt-d: Identify domains using first level page table Thread-Index: AQHVcgpG/pXRrE8O1EK3Luw5SA+K6qc7cLwAgACSPnA= Date: Wed, 25 Sep 2019 07:35:23 +0000 Message-ID: References: <20190923122454.9888-1-baolu.lu@linux.intel.com> <20190923122454.9888-5-baolu.lu@linux.intel.com> <20190925065006.GN28074@xz-x1> In-Reply-To: <20190925065006.GN28074@xz-x1> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWNjOWZjYmUtYzc2MS00MjE2LWJkYmYtYzU2YTdhNGI0OWMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSnozQ1pmXC9STHptMktYYkRDZzRUWjJ6MUk0bzJ2NWgzcXIxXC9pK05WeW1VRkg5K2FVUWJyVG9jcUQyenU4cmdWIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Cc: Yi Sun , "Raj, Ashok" , "kvm@vger.kernel.org" , "Kumar, Sanjay K" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , Alex Williamson , David Woodhouse , "Sun, Yi Y" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org > From: Peter Xu [mailto:peterx@redhat.com] > Sent: Wednesday, September 25, 2019 2:50 PM > > On Mon, Sep 23, 2019 at 08:24:54PM +0800, Lu Baolu wrote: > > +/* > > + * Check and return whether first level is used by default for > > + * DMA translation. > > + */ > > +static bool first_level_by_default(void) > > +{ > > + struct dmar_drhd_unit *drhd; > > + struct intel_iommu *iommu; > > + > > + rcu_read_lock(); > > + for_each_active_iommu(iommu, drhd) > > + if (!sm_supported(iommu) || > > + !ecap_flts(iommu->ecap) || > > + !cap_caching_mode(iommu->cap)) > > + return false; > > + rcu_read_unlock(); > > + > > + return true; > > +} > > "If no caching mode, then we will not use 1st level." > > Hmm, does the vIOMMU needs to support caching-mode if with the > solution you proposed here? Caching mode is only necessary for > shadowing AFAICT, and after all you're going to use full-nested, > then... then I would think it's not needed. And if so, with this > patch 1st level will be disabled. Sounds like a paradox... > > I'm thinking what would be the big picture for this to work now: For > the vIOMMU, instead of exposing the caching-mode, I'm thinking maybe > we should expose it with ecap.FLTS=1 while we can keep ecap.SLTS=0 > then it's natural that we can only use 1st level translation in the > guest for all the domains (and I assume such an ecap value should > never happen on real hardware, am I right?). > yes, that's also the picture in my mind. :-) Thanks Kevin _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu