Re: [PATCH bpf-next 09/11] bpfilter: Add struct table

From: Song Liu <songliubraving@fb.com>
To: Dmitrii Banshchikov <me@ubique.spb.ru>
Cc: "open list:BPF (Safe dynamic programs and tools)" 
	<bpf@vger.kernel.org>, "ast@kernel.org" <ast@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>,
	"andrii@kernel.org" <andrii@kernel.org>,
	Martin Lau <kafai@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
	"kpsingh@kernel.org" <kpsingh@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Andrey Ignatov <rdna@fb.com>
Subject: Re: [PATCH bpf-next 09/11] bpfilter: Add struct table
Date: Thu, 20 May 2021 18:07:07 +0000	[thread overview]
Message-ID: <AAFF4E35-AD81-49C1-A1D1-250FF18AD126@fb.com> (raw)
In-Reply-To: <20210517225308.720677-10-me@ubique.spb.ru>

> On May 17, 2021, at 3:53 PM, Dmitrii Banshchikov <me@ubique.spb.ru> wrote:
> 
> A table keeps iptables' blob and an array of struct rule for this blob.
> The array of rules provides more convenient way to interact with blob's
> entries.
> 
> All tables are stored in table_ops_map map which is used for lookups.
> Also all tables are linked into a list that is used for freeing them.
> 
> Signed-off-by: Dmitrii Banshchikov <me@ubique.spb.ru>

[...]

> diff --git a/net/bpfilter/context.h b/net/bpfilter/context.h
> index c62c1ba4781c..2d9e3fafb0f8 100644
> --- a/net/bpfilter/context.h
> +++ b/net/bpfilter/context.h
> @@ -10,12 +10,15 @@
> 
> #include "match-ops-map.h"
> #include "target-ops-map.h"
> +#include "table-map.h"
> 
> struct context {
> 	FILE *log_file;
> 	int log_level;
> 	struct match_ops_map match_ops_map;
> 	struct target_ops_map target_ops_map;
> +	struct table_map table_map;
> +	struct list_head table_list;

How about we add table_list to struct table_map (and maybe rename it)?
I suspect that will make the code a little cleaner. 

Thanks,
Song

[...]