All of lore.kernel.org
 help / color / mirror / Atom feed
From: lidong chen <chen.lidong.kernel@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	aliguori@us.ibm.com, Rik van Riel <riel@redhat.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 3/6] KVM-GST: KVM Steal time accounting
Date: Mon, 31 Jan 2011 00:45:32 +0800	[thread overview]
Message-ID: <AANLkTi=-y7fk1HwiH8+_fSxbp_rif+MRzuhcNmwc38_V@mail.gmail.com> (raw)
In-Reply-To: <4D456FF9.2010309@redhat.com>

I think we can use performance counter.
use unhalted core cycles event, in the nmi callback funcation, count
which process is running .
if the vm exit is caused by nmi,discard it.
the system time of qemu process is the time steal by kvm.



2011/1/30 Avi Kivity <avi@redhat.com>:
> On 01/28/2011 09:52 PM, Glauber Costa wrote:
>>
>> This patch accounts steal time time in kernel/sched.
>> I kept it from last proposal, because I still see advantages
>> in it: Doing it here will give us easier access from scheduler
>> variables such as the cpu rq. The next patch shows an example of
>> usage for it.
>>
>> Since functions like account_idle_time() can be called from
>> multiple places, not only account_process_tick(), steal time
>> grabbing is repeated in each account function separatedely.
>>
>
> I accept that steal time is worthwhile, but do you have some way to
> demonstrate that the implementation actually works and is beneficial?
>
> Perhaps run two cpu-bound compute processes on one vcpu, overcommit that
> vcpu, and see what happens to the processing rate with and without steal
> time accounting.  I'd expect a fairer response with steal time accounting.
>
> --
> error compiling committee.c: too many arguments to function
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2011-01-30 16:45 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-28 19:52 [PATCH v2 0/6] KVM Steal time, new submission Glauber Costa
2011-01-28 19:52 ` [PATCH v2 1/6] KVM-HDR: KVM Steal time implementation Glauber Costa
2011-01-29  1:28   ` Rik van Riel
2011-01-28 19:52 ` [PATCH v2 2/6] KVM-HV: " Glauber Costa
2011-01-29  1:46   ` Rik van Riel
2011-01-30 13:13   ` Avi Kivity
2011-02-01 15:48     ` Glauber Costa
2011-02-01 17:09       ` Avi Kivity
2011-02-01 19:58         ` Glauber Costa
2011-02-02 10:09           ` Avi Kivity
2011-01-31 11:07   ` Peter Zijlstra
2011-01-28 19:52 ` [PATCH v2 3/6] KVM-GST: KVM Steal time accounting Glauber Costa
2011-01-29  1:16   ` Jeremy Fitzhardinge
2011-01-29  1:27     ` Glauber Costa
2011-01-29  1:53   ` Rik van Riel
2011-01-30 14:04   ` Avi Kivity
2011-01-30 16:45     ` lidong chen [this message]
2011-02-01 15:58       ` Glauber Costa
2011-02-01 15:57     ` Glauber Costa
2011-02-02 10:11       ` Avi Kivity
2011-02-02 10:51         ` Avi Kivity
2011-02-02 11:57           ` Glauber Costa
2011-01-28 19:52 ` [PATCH v2 4/6] KVM-GST: KVM Steal time registration Glauber Costa
2011-01-29  2:16   ` Rik van Riel
2011-01-30 13:16   ` Avi Kivity
2011-02-01 15:53     ` Glauber Costa
2011-02-01 16:17       ` Peter Zijlstra
2011-02-01 17:00         ` Glauber Costa
2011-02-01 17:44           ` Peter Zijlstra
2011-02-01 20:20             ` Venkatesh Pallipadi
2011-01-31 11:11   ` Peter Zijlstra
2011-01-28 19:52 ` [PATCH v2 5/6] KVM-GST: adjust scheduler cpu power Glauber Costa
2011-01-31 11:25   ` Peter Zijlstra
2011-01-31 11:27     ` Peter Zijlstra
2011-02-01 15:59     ` Glauber Costa
2011-02-01 16:19       ` Peter Zijlstra
2011-02-01 16:22         ` Glauber Costa
2011-02-01 18:59           ` Peter Zijlstra
2011-02-01 19:55             ` Glauber Costa
2011-02-01 20:04               ` Peter Zijlstra
2011-01-28 19:52 ` [PATCH v2 6/6] Describe KVM_MSR_STEAL_TIME Glauber Costa
2011-01-30 13:19   ` Avi Kivity
2011-02-01 15:54     ` Glauber Costa
2011-02-02 10:14       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=-y7fk1HwiH8+_fSxbp_rif+MRzuhcNmwc38_V@mail.gmail.com' \
    --to=chen.lidong.kernel@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=glommer@redhat.com \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.