From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <1292875718-7980-2-git-send-email-sboyd@codeaurora.org> References: <1292649385-28771-1-git-send-email-sboyd@codeaurora.org> <1292875718-7980-1-git-send-email-sboyd@codeaurora.org> <1292875718-7980-2-git-send-email-sboyd@codeaurora.org> Date: Mon, 20 Dec 2010 16:49:52 -0500 Message-ID: Subject: Re: [PATCH 1/3] hvc_dcc: Fix bad code generation by marking assembly volatile From: Arnaud Lacombe Content-Type: text/plain; charset=ISO-8859-1 To: Stephen Boyd Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Arnd Bergmann , Nicolas Pitre , Daniel Walker List-ID: Hi, On Mon, Dec 20, 2010 at 3:08 PM, Stephen Boyd wrote: > Without marking the asm __dcc_getstatus() volatile my compiler > decides [...] What compiler ? That might be a usefull information to know, espectially 5 years from now when tracing code history. There has been similar issue with gcc 4.5 recently. AFAIK, in the same idea, the final change has been to mark the asm volatile. Thanks, - Arnaud From mboxrd@z Thu Jan 1 00:00:00 1970 From: lacombar@gmail.com (Arnaud Lacombe) Date: Mon, 20 Dec 2010 16:49:52 -0500 Subject: [PATCH 1/3] hvc_dcc: Fix bad code generation by marking assembly volatile In-Reply-To: <1292875718-7980-2-git-send-email-sboyd@codeaurora.org> References: <1292649385-28771-1-git-send-email-sboyd@codeaurora.org> <1292875718-7980-1-git-send-email-sboyd@codeaurora.org> <1292875718-7980-2-git-send-email-sboyd@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Mon, Dec 20, 2010 at 3:08 PM, Stephen Boyd wrote: > Without marking the asm __dcc_getstatus() volatile my compiler > decides [...] What compiler ? That might be a usefull information to know, espectially 5 years from now when tracing code history. There has been similar issue with gcc 4.5 recently. AFAIK, in the same idea, the final change has been to mark the asm volatile. Thanks, - Arnaud