From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Bohmer <linux@bohmer.net>
Date: Sat, 14 Aug 2010 17:44:13 +0200
Subject: [U-Boot] [PATCH V2 1/2] USB-CDC: correct wrong alignment in
	ether.c
In-Reply-To: <4C668AC6.3000003@mvista.com>
References: <1281773943-16455-1-git-send-email-sbabic@denx.de>
	<4C668AC6.3000003@mvista.com>
Message-ID: <AANLkTi=AgW1igYdCgmKyKpnGaxaf85p1OYqCfihAiVib@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

2010/8/14 Sergei Shtylyov <sshtylyov@mvista.com>:
> Hello.
>
> Stefano Babic wrote:
>
>> The buffer for the status request must be word aligned
>> because it is accessed with 32 bit pointer in the
>> eth_status_complete function.
>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>
> [...]
>>
>> diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
>> index 313f15f..0b4ed18 100644
>> --- a/drivers/usb/gadget/ether.c
>> +++ b/drivers/usb/gadget/ether.c
>> @@ -684,7 +684,7 @@ static struct usb_gadget_strings ? ?stringtab = {
>>
>> ?/*============================================================================*/
>> ?static u8 control_req[USB_BUFSIZ];
>> -static u8 status_req[STATUS_BYTECOUNT];
>> +static u8 status_req[STATUS_BYTECOUNT] __attribute__ ((aligned(32)));
>
> ? You're aligning to 32 *bytes* -- is that what you meant by "32 bit
> pointer"?

Whoops... Good remark... Overlooked it myself...
Unapplied it...

Kind regards,

Remy