All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Bagwell <chris@cnpbagwell.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Chase Douglas <chase.douglas@canonical.com>,
	linux-input@vger.kernel.org, xorg-devel@lists.x.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Andy Whitcroft <apw@canonical.com>,
	Henrik Rydberg <rydberg@euromail.se>,
	linux-kernel@vger.kernel.org,
	Peter Hutterer <peter.hutterer@who-t.net>,
	Duncan McGreggor <duncan.mcgreggor@canonical.com>
Subject: Re: [PATCH 3/3] Input: synaptics - remove touches over button click area
Date: Mon, 11 Oct 2010 12:46:40 -0500	[thread overview]
Message-ID: <AANLkTi=G3xYm5+Wqv0quGGUhDEd7x8r7WJhN-tb6G=TA@mail.gmail.com> (raw)
In-Reply-To: <s5h7hho3bau.wl%tiwai@suse.de>

On Mon, Oct 11, 2010 at 12:10 PM, Takashi Iwai <tiwai@suse.de> wrote:
> At Mon, 11 Oct 2010 11:24:04 -0500,
> Chris Bagwell wrote:
>>
>> On Fri, Oct 8, 2010 at 9:58 AM, Chase Douglas
>> <chase.douglas@canonical.com> wrote:
>> > Now that we have proper multitouch support, we can handle integrated
>> > buttons better. If we know the top of the buttons on the touchpad, we
>> > can ignore any touches that occur within the touchpad area while a
>> > button is clicked. It may be possible to get the button area by querying
>> > the device, but for now allow the user to manually set it.
>> >
>> > A note on why this works: the Synaptics touchpads have pseudo touch
>> > tracking. When two touches are on the touchpad, an MT touch packet with
>> > just the X, Y, and pressure values is sent before a normal Synaptics
>> > touch packet. When one touch is obviously in motion and the other is
>> > stationary, the touchpad controller sends the touch in motion in the
>> > normal packet and the stationary touch in the MT packet. Single touch
>> > emulation is provided by the normal packet, so an action like clicking
>> > a button and dragging with another finger still works as expected.
>> >
>> > Tested on a Dell Mini 1012 with synaptics_multitouch=1 and
>> > synaptics_button_thresh=4100.
>> >
>> > Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
>> > ---
>> >  drivers/input/mouse/synaptics.c |   16 +++++++++++++++-
>> >  1 files changed, 15 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
>> > index 7289d88..e67778d 100644
>> > --- a/drivers/input/mouse/synaptics.c
>> > +++ b/drivers/input/mouse/synaptics.c
>> > @@ -49,6 +49,12 @@ module_param(synaptics_multitouch, bool, 0644);
>> >  MODULE_PARM_DESC(synaptics_multitouch,
>> >                 "Enable multitouch mode on Synaptics devices");
>> >
>> > +static int synaptics_button_thresh = YMIN_NOMINAL + YMAX_NOMINAL;
>> > +module_param(synaptics_button_thresh, int, 0644);
>> > +MODULE_PARM_DESC(synaptics_button_thres,
>> > +                "Y coordinate threshold of integrated buttons on Synaptics "
>> > +                "devices");
>> > +
>> >  /*****************************************************************************
>> >  *     Stuff we need even when we do not want native Synaptics support
>> >  ****************************************************************************/
>> > @@ -463,6 +469,10 @@ static void synaptics_parse_hw_state(unsigned char buf[], struct synaptics_data
>> >        }
>> >  }
>> >
>> > +#define TOUCH_OVER_BUTTON(hw) (((hw).left || (hw).middle || (hw).right) && \
>> > +                              (YMAX_NOMINAL + YMIN_NOMINAL - (hw).y > \
>> > +                               synaptics_button_thresh))
>> > +
>> >  /*
>> >  *  called for each full received packet from the touchpad
>> >  */
>> > @@ -477,7 +487,7 @@ static void synaptics_process_packet(struct psmouse *psmouse)
>> >        synaptics_parse_hw_state(psmouse->packet, priv, &hw);
>> >
>> >        if (SYN_MULTITOUCH(priv, &hw)) {
>> > -               if (hw.z > 0) {
>> > +               if (hw.z > 0 && !TOUCH_OVER_BUTTON(hw)) {
>> >                        input_report_abs(dev, ABS_MT_POSITION_X, hw.x);
>> >                        input_report_abs(dev, ABS_MT_POSITION_Y,
>> >                                         YMAX_NOMINAL + YMIN_NOMINAL - hw.y);
>> > @@ -509,6 +519,10 @@ static void synaptics_process_packet(struct psmouse *psmouse)
>> >                return;
>> >        }
>> >
>> > +       /* If touch occurs over depressed button, ignore it */
>> > +       if (TOUCH_OVER_BUTTON(hw))
>> > +               hw.z = 0;
>> > +
>> >        if (hw.z > 0) {
>> >                priv->num_fingers++;
>> >                finger_width = 5;
>> > --
>> > 1.7.1
>> >
>> >
>>
>> I'm convinced now that clickpad style touchpads can't work without
>> multi-touch and something like logic in xf86-input-multitouch.
>
> Actually Clickpad works without multi-touch patch.  With my patches to
> synaptics, it worked in some level.  There are many restrictions (e.g.
> pushing the button first then drag), though.
>

True, but if I understand synaptic hardware MT behavior (sends
actively moving finger in higher resolution packet regardless of
original finger touch) then your patch will result in jumpy cursor on
X side and that side would need patches to attempt to guess invalid
data and discard.  I've worked on a few similar patches to various
xf86-input-* and generally they've failed to detect difference between
invalid packets vs. fast user movements.

The main point of my 3 options was to address jumpy cursor in
xf86-input-* that are not MT aware.  I think ABS_X/ABS_Y should only
allow its meaning to change at detectable time periods so user can
account for it and, specifically, that time period is best at
transition of BTN_TOOL_DOUBLETAP.

Assuming its easy enough to support exact rules for ABS_X/ABS_Y
changing meanings on kernel side (which I think it probably is pretty
easy), I think we should do it so that applications don't have to
become MT-aware as the official solution for jumpy cursors.

Chris

WARNING: multiple messages have this Message-ID (diff)
From: Chris Bagwell <chris@cnpbagwell.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Chase Douglas <chase.douglas@canonical.com>,
	linux-input@vger.kernel.org, xorg-devel@lists.x.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Andy Whitcroft <apw@canonical.com>,
	Henrik Rydberg <rydberg@euromail.se>,
	linux-kernel@vger.kernel.org,
	Peter Hutterer <peter.hutterer@who-t.net>,
	Duncan McGreggor <duncan.mcgreggor@canonical.com>
Subject: Re: [PATCH 3/3] Input: synaptics - remove touches over button click area
Date: Mon, 11 Oct 2010 12:46:40 -0500	[thread overview]
Message-ID: <AANLkTi=G3xYm5+Wqv0quGGUhDEd7x8r7WJhN-tb6G=TA@mail.gmail.com> (raw)
In-Reply-To: <s5h7hho3bau.wl%tiwai@suse.de>

On Mon, Oct 11, 2010 at 12:10 PM, Takashi Iwai <tiwai@suse.de> wrote:
> At Mon, 11 Oct 2010 11:24:04 -0500,
> Chris Bagwell wrote:
>>
>> On Fri, Oct 8, 2010 at 9:58 AM, Chase Douglas
>> <chase.douglas@canonical.com> wrote:
>> > Now that we have proper multitouch support, we can handle integrated
>> > buttons better. If we know the top of the buttons on the touchpad, we
>> > can ignore any touches that occur within the touchpad area while a
>> > button is clicked. It may be possible to get the button area by querying
>> > the device, but for now allow the user to manually set it.
>> >
>> > A note on why this works: the Synaptics touchpads have pseudo touch
>> > tracking. When two touches are on the touchpad, an MT touch packet with
>> > just the X, Y, and pressure values is sent before a normal Synaptics
>> > touch packet. When one touch is obviously in motion and the other is
>> > stationary, the touchpad controller sends the touch in motion in the
>> > normal packet and the stationary touch in the MT packet. Single touch
>> > emulation is provided by the normal packet, so an action like clicking
>> > a button and dragging with another finger still works as expected.
>> >
>> > Tested on a Dell Mini 1012 with synaptics_multitouch=1 and
>> > synaptics_button_thresh=4100.
>> >
>> > Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
>> > ---
>> >  drivers/input/mouse/synaptics.c |   16 +++++++++++++++-
>> >  1 files changed, 15 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
>> > index 7289d88..e67778d 100644
>> > --- a/drivers/input/mouse/synaptics.c
>> > +++ b/drivers/input/mouse/synaptics.c
>> > @@ -49,6 +49,12 @@ module_param(synaptics_multitouch, bool, 0644);
>> >  MODULE_PARM_DESC(synaptics_multitouch,
>> >                 "Enable multitouch mode on Synaptics devices");
>> >
>> > +static int synaptics_button_thresh = YMIN_NOMINAL + YMAX_NOMINAL;
>> > +module_param(synaptics_button_thresh, int, 0644);
>> > +MODULE_PARM_DESC(synaptics_button_thres,
>> > +                "Y coordinate threshold of integrated buttons on Synaptics "
>> > +                "devices");
>> > +
>> >  /*****************************************************************************
>> >  *     Stuff we need even when we do not want native Synaptics support
>> >  ****************************************************************************/
>> > @@ -463,6 +469,10 @@ static void synaptics_parse_hw_state(unsigned char buf[], struct synaptics_data
>> >        }
>> >  }
>> >
>> > +#define TOUCH_OVER_BUTTON(hw) (((hw).left || (hw).middle || (hw).right) && \
>> > +                              (YMAX_NOMINAL + YMIN_NOMINAL - (hw).y > \
>> > +                               synaptics_button_thresh))
>> > +
>> >  /*
>> >  *  called for each full received packet from the touchpad
>> >  */
>> > @@ -477,7 +487,7 @@ static void synaptics_process_packet(struct psmouse *psmouse)
>> >        synaptics_parse_hw_state(psmouse->packet, priv, &hw);
>> >
>> >        if (SYN_MULTITOUCH(priv, &hw)) {
>> > -               if (hw.z > 0) {
>> > +               if (hw.z > 0 && !TOUCH_OVER_BUTTON(hw)) {
>> >                        input_report_abs(dev, ABS_MT_POSITION_X, hw.x);
>> >                        input_report_abs(dev, ABS_MT_POSITION_Y,
>> >                                         YMAX_NOMINAL + YMIN_NOMINAL - hw.y);
>> > @@ -509,6 +519,10 @@ static void synaptics_process_packet(struct psmouse *psmouse)
>> >                return;
>> >        }
>> >
>> > +       /* If touch occurs over depressed button, ignore it */
>> > +       if (TOUCH_OVER_BUTTON(hw))
>> > +               hw.z = 0;
>> > +
>> >        if (hw.z > 0) {
>> >                priv->num_fingers++;
>> >                finger_width = 5;
>> > --
>> > 1.7.1
>> >
>> >
>>
>> I'm convinced now that clickpad style touchpads can't work without
>> multi-touch and something like logic in xf86-input-multitouch.
>
> Actually Clickpad works without multi-touch patch.  With my patches to
> synaptics, it worked in some level.  There are many restrictions (e.g.
> pushing the button first then drag), though.
>

True, but if I understand synaptic hardware MT behavior (sends
actively moving finger in higher resolution packet regardless of
original finger touch) then your patch will result in jumpy cursor on
X side and that side would need patches to attempt to guess invalid
data and discard.  I've worked on a few similar patches to various
xf86-input-* and generally they've failed to detect difference between
invalid packets vs. fast user movements.

The main point of my 3 options was to address jumpy cursor in
xf86-input-* that are not MT aware.  I think ABS_X/ABS_Y should only
allow its meaning to change at detectable time periods so user can
account for it and, specifically, that time period is best at
transition of BTN_TOOL_DOUBLETAP.

Assuming its easy enough to support exact rules for ABS_X/ABS_Y
changing meanings on kernel side (which I think it probably is pretty
easy), I think we should do it so that applications don't have to
become MT-aware as the official solution for jumpy cursors.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-10-11 17:46 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 14:57 [PATCH 0/3] Input: synaptics - multitouch and multifinger support Chase Douglas
2010-10-08 14:57 ` [PATCH 1/3] Input: synaptics - add multitouch support Chase Douglas
2010-10-08 14:57   ` [PATCH 2/3] Input: synaptics - add multitouch multifinger support Chase Douglas
2010-10-08 14:58     ` [PATCH 3/3] Input: synaptics - remove touches over button click area Chase Douglas
2010-10-10 15:58       ` Chris Bagwell
2010-10-11 16:24       ` Chris Bagwell
2010-10-11 16:24         ` Chris Bagwell
2010-10-11 17:10         ` Takashi Iwai
2010-10-11 17:10           ` Takashi Iwai
2010-10-11 17:30           ` Dmitry Torokhov
2010-10-11 17:30             ` Dmitry Torokhov
2010-10-11 17:40             ` Takashi Iwai
2010-10-11 17:46           ` Chris Bagwell [this message]
2010-10-11 17:46             ` Chris Bagwell
2010-10-11 17:54             ` Henrik Rydberg
2010-10-11 18:29             ` Takashi Iwai
2010-10-11 18:29               ` Takashi Iwai
2010-10-10 15:44     ` [PATCH 2/3] Input: synaptics - add multitouch multifinger support Chris Bagwell
2010-10-10 15:37   ` [PATCH 1/3] Input: synaptics - add multitouch support Chris Bagwell
2010-10-10 15:41   ` Chris Bagwell
2010-10-08 16:37 ` [PATCH 0/3] Input: synaptics - multitouch and multifinger support Takashi Iwai
2010-10-08 16:38   ` Takashi Iwai
2010-10-08 17:48     ` Takashi Iwai
2010-10-08 17:15   ` Chase Douglas
2010-10-08 17:46     ` Takashi Iwai
2010-10-08 18:04     ` Dmitry Torokhov
2010-10-08 19:31       ` Takashi Iwai
2010-10-10 21:04         ` Dmitry Torokhov
2010-10-11  7:35           ` Takashi Iwai
2010-10-11  7:48             ` Henrik Rydberg
2010-10-11  7:59               ` Takashi Iwai
2010-10-11 13:41               ` Chris Bagwell
2010-10-11 13:41                 ` Chris Bagwell
2010-10-11 14:01                 ` Takashi Iwai
2010-10-11 14:01                   ` Takashi Iwai
2010-10-11 14:24                   ` Henrik Rydberg
2010-10-11 14:49                     ` Takashi Iwai
2010-10-11 15:31                       ` Henrik Rydberg
2010-10-11 15:58                         ` Takashi Iwai
2010-10-10  7:49   ` Henrik Rydberg
2010-10-10 20:59     ` Dmitry Torokhov
2010-10-11  7:28       ` Takashi Iwai
2010-10-11  7:40         ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=G3xYm5+Wqv0quGGUhDEd7x8r7WJhN-tb6G=TA@mail.gmail.com' \
    --to=chris@cnpbagwell.com \
    --cc=apw@canonical.com \
    --cc=chase.douglas@canonical.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=duncan.mcgreggor@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    --cc=rydberg@euromail.se \
    --cc=tiwai@suse.de \
    --cc=xorg-devel@lists.x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.