From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755069Ab0KSPof (ORCPT ); Fri, 19 Nov 2010 10:44:35 -0500 Received: from na3sys009aog109.obsmtp.com ([74.125.149.201]:55805 "HELO na3sys009aog109.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752004Ab0KSPoe convert rfc822-to-8bit (ORCPT ); Fri, 19 Nov 2010 10:44:34 -0500 X-Greylist: delayed 379 seconds by postgrey-1.27 at vger.kernel.org; Fri, 19 Nov 2010 10:44:33 EST MIME-Version: 1.0 In-Reply-To: References: <95f48a32a0256ecdb7148aa08d16f64928a7e5d8.1289935504.git.bengardiner@nanometrics.ca> Date: Fri, 19 Nov 2010 10:38:10 -0500 Message-ID: Subject: Re: [PATCH v2 2/4] da850-evm: add UI Expander pushbuttons From: Ben Gardiner To: "Nori, Sekhar" Cc: Kevin Hilman , "davinci-linux-open-source@linux.davincidsp.com" , "linux-input@vger.kernel.org" , Dmitry Torokhov , "Govindarajan, Sriramakrishnan" , Paul Mundt , "linux-kernel@vger.kernel.org" , Alexander Clouter , Chris Cordahi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sekhar, Thank you for your reviews. On Fri, Nov 19, 2010 at 4:58 AM, Nori, Sekhar wrote: > [...] > On Wed, Nov 17, 2010 at 01:09:35, Ben Gardiner wrote: >> [...] >> Changes since v1: >>  * set INPUT_POLLDEV default for DA850_EVM machine, but don't select it >>    unconditionally > > I didn't see the v1 posting (wonder why), but why is this > required? Why cant we depend on this being selected from > Device Drivers->Input device support in menuconfig? I'm sorry about that. I checked gmane and the v1 never made it to the davinci-linux list. I think it was because of my (mis)use of git send-email. Version 2 made it to the list so I've now found the magic incantation. The reason we should at least select INPUT_POLLDEV as a default option is: when it is not set the gpio-keys instances registered by the da850-evm board setup routine will fail probe() of the gpio-keys driver since it will not have polled-input support enabled. By setting INPUT_POLLDEV default for the da850-evm users will get functioning pushbuttons and switches with the default config but they will be able to disable INPUT_POLLDEV or gpio-keys drivers in their defconfig at their convenience. > [...] > >> @@ -349,6 +421,10 @@ static struct i2c_board_info __initdata da850_evm_i2c_devices[] = { >>       { >>               I2C_BOARD_INFO("tca6416", 0x20), >>               .platform_data = &da850_evm_ui_expander_info, >> +             /* >> +              * TODO : populate at runtime using >> +              * .irq = gpio_to_irq(GPIO_TO_PIN(2,7)), >> +              */ > > You seem to be adding this in this patch and removing > in 4/4. Oops. That's my fault. The internal reviewers also reminded me to remove these before sending. Sorry for the noise/ I will remove this block in _this_ patch in the re-spin. Best Regards, Ben Gardiner --- Nanometrics Inc. http://www.nanometrics.ca From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Gardiner Subject: Re: [PATCH v2 2/4] da850-evm: add UI Expander pushbuttons Date: Fri, 19 Nov 2010 10:38:10 -0500 Message-ID: References: <95f48a32a0256ecdb7148aa08d16f64928a7e5d8.1289935504.git.bengardiner@nanometrics.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from na3sys009aog103.obsmtp.com ([74.125.149.71]:42606 "HELO na3sys009aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754946Ab0KSPiP convert rfc822-to-8bit (ORCPT ); Fri, 19 Nov 2010 10:38:15 -0500 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Nori, Sekhar" Cc: Kevin Hilman , "davinci-linux-open-source@linux.davincidsp.com" , "linux-input@vger.kernel.org" , Dmitry Torokhov , "Govindarajan, Sriramakrishnan" , Paul Mundt , "linux-kernel@vger.kernel.org" , Alexander Clouter , Chris Cordahi Hi Sekhar, Thank you for your reviews. On Fri, Nov 19, 2010 at 4:58 AM, Nori, Sekhar wrote: > [...] > On Wed, Nov 17, 2010 at 01:09:35, Ben Gardiner wrote: >> [...] >> Changes since v1: >> =A0* set INPUT_POLLDEV default for DA850_EVM machine, but don't sele= ct it >> =A0 =A0unconditionally > > I didn't see the v1 posting (wonder why), but why is this > required? Why cant we depend on this being selected from > Device Drivers->Input device support in menuconfig? I'm sorry about that. I checked gmane and the v1 never made it to the davinci-linux list. I think it was because of my (mis)use of git send-email. Version 2 made it to the list so I've now found the magic incantation. The reason we should at least select INPUT_POLLDEV as a default option is: when it is not set the gpio-keys instances registered by the da850-evm board setup routine will fail probe() of the gpio-keys driver since it will not have polled-input support enabled. By setting INPUT_POLLDEV default for the da850-evm users will get functioning pushbuttons and switches with the default config but they will be able to disable INPUT_POLLDEV or gpio-keys drivers in their defconfig at their convenience. > [...] > >> @@ -349,6 +421,10 @@ static struct i2c_board_info __initdata da850_e= vm_i2c_devices[] =3D { >> =A0 =A0 =A0 { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 I2C_BOARD_INFO("tca6416", 0x20), >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 .platform_data =3D &da850_evm_ui_expande= r_info, >> + =A0 =A0 =A0 =A0 =A0 =A0 /* >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0* TODO : populate at runtime using >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0* .irq =3D gpio_to_irq(GPIO_TO_PIN(2,7)= ), >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0*/ > > You seem to be adding this in this patch and removing > in 4/4. Oops. That's my fault. The internal reviewers also reminded me to remove these before sending. Sorry for the noise/ I will remove this block in _this_ patch in the re-spin. Best Regards, Ben Gardiner --- Nanometrics Inc. http://www.nanometrics.ca -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html