From: Randolph Chung <rchung42@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH v2] Add support for tlv320aic3007 to tlv320aic3x codec.
Date: Fri, 20 Aug 2010 22:58:20 +0800 [thread overview]
Message-ID: <AANLkTi=O=6WSje5dxytsO+EG6T2ksnyqw42PvZs12Kav@mail.gmail.com> (raw)
In-Reply-To: <20100820110840.GF13668@rakim.wolfsonmicro.main>
> Applied but...
>
>> +static const struct i2c_device_id aic3x_i2c_id[] = {
>> + [AIC3X_MODEL_3X] = { "tlv320aic3x", 0 },
>> + [AIC3X_MODEL_33] = { "tlv320aic33", 0 },
>> + [AIC3X_MODEL_3007] = { "tlv320aic3007", 0 },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(i2c, aic3x_i2c_id);
>
> The more idiomatic way to write this stuff is:
>
> { "tlv320aic3007", AIC3X_MODEL_3007 }
>
> and then look at the id field in the probe() function. Could you send a
> followup patch doing that, please?
The second field in that struct is normally the i2c address, so this
seems a bit confusing...
randolph
next prev parent reply other threads:[~2010-08-20 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 4:47 [PATCH v2] Add support for tlv320aic3007 to tlv320aic3x codec Randolph Chung
2010-08-20 10:39 ` Liam Girdwood
2010-08-20 11:08 ` Mark Brown
2010-08-20 14:58 ` Randolph Chung [this message]
2010-08-20 15:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=O=6WSje5dxytsO+EG6T2ksnyqw42PvZs12Kav@mail.gmail.com' \
--to=rchung42@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.