All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: Koen Kooi <koen@openembedded.org>, Steve Sakoman <steve@sakoman.com>
Subject: Re: [PATCH 1/2] u-boot-sakoman: fix break caused by the new binutils
Date: Mon, 24 Jan 2011 07:47:07 -0800	[thread overview]
Message-ID: <AANLkTi=RgH9E_BoebNBxTqfB4AktF1M1npuAqfxz8To4@mail.gmail.com> (raw)
In-Reply-To: <97b6dd6720dcdcdbd27616740b3707bc108a4927.1295880053.git.vjaquez@igalia.com>

2011/1/24 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>:
> New assemblers need -march=armv7-a+sec on command line or .arch_extension sec
> inline to enable use of the smc instruction.
>
> This patch adds as-instr to check the latter to conditionally enable the
> former in AFLAGS for files that use smc.
>
> Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>

Acked-by: Khem Raj <raj.khem@gmail.com>

> ---
>  .../fix-break-caused-by-new-binutils.patch         |   31 ++++++++++++++++++++
>  recipes/u-boot/u-boot-sakoman_git.bb               |    1 +
>  2 files changed, 32 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/u-boot/u-boot-sakoman/fix-break-caused-by-new-binutils.patch
>
> diff --git a/recipes/u-boot/u-boot-sakoman/fix-break-caused-by-new-binutils.patch b/recipes/u-boot/u-boot-sakoman/fix-break-caused-by-new-binutils.patch
> new file mode 100644
> index 0000000..16bc980
> --- /dev/null
> +++ b/recipes/u-boot/u-boot-sakoman/fix-break-caused-by-new-binutils.patch
> @@ -0,0 +1,31 @@
> +Index: git/arch/arm/cpu/armv7/omap4/Makefile
> +===================================================================
> +--- git.orig/arch/arm/cpu/armv7/omap4/Makefile
> ++++ git/arch/arm/cpu/armv7/omap4/Makefile
> +@@ -26,6 +26,8 @@ include $(TOPDIR)/config.mk
> + LIB   =  $(obj)lib$(SOC).o
> +
> + SOBJS += lowlevel_init.o
> ++plus_sec := $(call as-instr,.arch_extension sec,+sec)
> ++lowlevel_init.o: AFLAGS += -Wa,-march=armv7-a$(plus_sec)
> +
> + COBJS += board.o
> + COBJS += mem.o
> +Index: git/config.mk
> +===================================================================
> +--- git.orig/config.mk
> ++++ git/config.mk
> +@@ -266,3 +266,13 @@ cmd_link_o_target = $(if $(strip $1),\
> +                     rm -f $@; $(AR) rcs $@ )
> +
> + #########################################################################
> ++
> ++# Tries to compile an assembly instruction
> ++as-instr = $(shell if echo -e "$(1)" | \
> ++            $(CC) $(AFLAGS) -c -xassembler - \
> ++             -o $(TMPOUT)astest$$$$.out > /dev/null 2>&1; \
> ++         then rm $(TMPOUT)astest$$$$.out; echo "$(2)"; \
> ++         else echo "$(3)"; fi)
> ++
> ++#########################################################################
> ++
> diff --git a/recipes/u-boot/u-boot-sakoman_git.bb b/recipes/u-boot/u-boot-sakoman_git.bb
> index 5b9ff11..8dfe713 100644
> --- a/recipes/u-boot/u-boot-sakoman_git.bb
> +++ b/recipes/u-boot/u-boot-sakoman_git.bb
> @@ -7,6 +7,7 @@ SRCREV = "261733408a27d14590cf3ec6b596461808050e32"
>  PV = "2010.12+${PR}+git${SRCREV}"
>
>  SRC_URI = "git://www.sakoman.com/git/u-boot.git;branch=omap4-exp;protocol=git \
> +          file://fix-break-caused-by-new-binutils.patch \
>           "
>  S = "${WORKDIR}/git"
>
> --
> 1.7.0.2
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



  reply	other threads:[~2011-01-24 15:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 14:48 [PATCH 0/2] fixes for binutils 2.21 Víctor Manuel Jáquez Leal
2011-01-24 14:48 ` [PATCH 1/2] u-boot-sakoman: fix break caused by the new binutils Víctor Manuel Jáquez Leal
2011-01-24 15:47   ` Khem Raj [this message]
     [not found]   ` <1295882416.1999.8.camel@quadra>
2011-01-24 17:18     ` Víctor M. Jáquez L.
     [not found]       ` <1295890383.1999.11.camel@quadra>
2011-01-24 18:37         ` Víctor M. Jáquez L.
2011-01-24 14:48 ` [PATCH 2/2] linux-omap4: " Víctor Manuel Jáquez Leal
2011-01-24 15:48   ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=RgH9E_BoebNBxTqfB4AktF1M1npuAqfxz8To4@mail.gmail.com' \
    --to=raj.khem@gmail.com \
    --cc=koen@openembedded.org \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.