All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] test: Add realmode test for 2 op imul instruction (0x0f 0xaf)
@ 2010-08-18 17:41 Mohammed Gamal
  2010-08-23 23:33 ` Marcelo Tosatti
  0 siblings, 1 reply; 3+ messages in thread
From: Mohammed Gamal @ 2010-08-18 17:41 UTC (permalink / raw)
  To: avi; +Cc: kvm, Mohammed Gamal

Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
---
 x86/realmode.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)

diff --git a/x86/realmode.c b/x86/realmode.c
index 603fd1f..63ee868 100644
--- a/x86/realmode.c
+++ b/x86/realmode.c
@@ -1004,6 +1004,14 @@ void test_imul()
 			"mov $4, %ecx\n\t"
 			"imul %ecx\n\t");
 
+	MK_INSN(imul16_3, "mov $2, %bx\n\t"
+			  "mov $4, %cx\n\t"
+			  "imul %bx, %cx\n\t");
+
+	MK_INSN(imul32_3, "mov $2, %ebx\n\t"
+			 "mov $4, %ecx\n\t"
+			 "imul %ebx, %ecx\n\t");
+
 	exec_in_big_real_mode(&inregs, &outregs,
 			      insn_imul8_1,
 			      insn_imul8_1_end - insn_imul8_1);
@@ -1058,6 +1066,24 @@ void test_imul()
 		print_serial("imul Test 6: FAIL\n");
 	else
 		print_serial("imul Test 6: PASS\n");
+
+	exec_in_big_real_mode(&inregs, &outregs,
+                              insn_imul16_3,
+                              insn_imul16_3_end - insn_imul16_3);
+
+        if (!regs_equal(&inregs, &outregs, R_BX | R_CX) || outregs.ecx != 8)
+                print_serial("imul Test 7: FAIL\n");
+        else
+                print_serial("imul Test 7: PASS\n");
+
+        exec_in_big_real_mode(&inregs, &outregs,
+                              insn_imul32_3,
+                              insn_imul32_3_end - insn_imul32_3);
+
+        if (!regs_equal(&inregs, &outregs, R_BX | R_CX) || outregs.ecx != 8)
+                print_serial("imul Test 8: FAIL\n");
+        else
+                print_serial("imul Test 8: PASS\n");
 }
 
 void test_mul()
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: Add realmode test for 2 op imul instruction (0x0f 0xaf)
  2010-08-18 17:41 [PATCH] test: Add realmode test for 2 op imul instruction (0x0f 0xaf) Mohammed Gamal
@ 2010-08-23 23:33 ` Marcelo Tosatti
  2010-08-24  2:24   ` Mohammed Gamal
  0 siblings, 1 reply; 3+ messages in thread
From: Marcelo Tosatti @ 2010-08-23 23:33 UTC (permalink / raw)
  To: Mohammed Gamal; +Cc: avi, kvm

On Wed, Aug 18, 2010 at 08:41:37PM +0300, Mohammed Gamal wrote:
> Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
> ---
>  x86/realmode.c |   26 ++++++++++++++++++++++++++
>  1 files changed, 26 insertions(+), 0 deletions(-)

Please rebase.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: Add realmode test for 2 op imul instruction (0x0f 0xaf)
  2010-08-23 23:33 ` Marcelo Tosatti
@ 2010-08-24  2:24   ` Mohammed Gamal
  0 siblings, 0 replies; 3+ messages in thread
From: Mohammed Gamal @ 2010-08-24  2:24 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: avi, kvm

On Tue, Aug 24, 2010 at 2:33 AM, Marcelo Tosatti <mtosatti@redhat.com> wrote:
> On Wed, Aug 18, 2010 at 08:41:37PM +0300, Mohammed Gamal wrote:
>> Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
>> ---
>>  x86/realmode.c |   26 ++++++++++++++++++++++++++
>>  1 files changed, 26 insertions(+), 0 deletions(-)
>
> Please rebase.
>
>

The patch is no longer relevant. Avi already implemented similar tests

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-08-24  2:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-18 17:41 [PATCH] test: Add realmode test for 2 op imul instruction (0x0f 0xaf) Mohammed Gamal
2010-08-23 23:33 ` Marcelo Tosatti
2010-08-24  2:24   ` Mohammed Gamal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.