From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pedro Ribeiro Subject: Re: 2.6.37 intel driver crash on hibernate Date: Wed, 9 Feb 2011 11:48:31 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0655377328==" Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AB719E763 for ; Wed, 9 Feb 2011 03:48:33 -0800 (PST) Received: by wyf22 with SMTP id 22so66809wyf.36 for ; Wed, 09 Feb 2011 03:48:32 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0655377328== Content-Type: multipart/alternative; boundary=002215974932540936049bd80b0d --002215974932540936049bd80b0d Content-Type: text/plain; charset=ISO-8859-1 On 9 February 2011 09:40, Chris Wilson wrote: > On Wed, 9 Feb 2011 00:27:52 +0000, Pedro Ribeiro wrote: > > Hi, > > > > I've been having unreliable operation when hibernating ever since > 2.6.37-rc5 > > (the first 2.6.37 I tried). > > With 2.6.36 I never had a problem. > > Wrong, you just never saw it. > > commit 9334ef755f060e251f3f395caeda1a58b6834ea3 > Author: Chris Wilson > Date: Fri Jan 28 11:53:03 2011 +0000 > > drm: Don't switch fb when disabling an output > > In drm_crtc_helper_set_config, we call drm_crtc_helper_set_mode which > may return early and do no operation if the crtc is to be disabled. In > this case we merrily swap to the new fb, discarding the old_fb believing > that it has been cleaned up. However, due to the early return, the > old_fb was not presented to the backend for correct reaping, and nor was > the new one - which is about to be reaped via the > drm_helper_disable_unused_functions(), leading to incorrect refcounting > of the pinned objects. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=27722 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29857 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29230 > Tested-by: Takashi Iwai > Signed-off-by: Chris Wilson > > -- > Chris Wilson, Intel Open Source Technology Centre > Thanks for the prompt reply. I assume this will be included in stable? For the moment I'll just apply the patch to my build. Regards, Pedro --002215974932540936049bd80b0d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On 9 February 2011 09:40, Chris Wilson <= span dir=3D"ltr"><chris@chri= s-wilson.co.uk> wrote:
On Wed, 9 Feb 2011 00:27:52 +0000, Pedro Ribeiro <pedrib@gmail.com> wrote:
> Hi,
>
> I've been having unreliable operation when hibernating ever since = 2.6.37-rc5
> (the first 2.6.37 I tried).
> With 2.6.36 I never had a problem.

Wrong, you just never saw it.

commit 9334ef755f060e251f3f395caeda1a58b6834ea3
Author: Chris Wilson <chris@= chris-wilson.co.uk>
Date: =A0 Fri Jan 28 11:53:03 2011 +0000

=A0 =A0drm: Don't switch fb when disabling an output

=A0 =A0In drm_crtc_helper_set_config, we call drm_crtc_helper_set_mode whi= ch
=A0 =A0may return early and do no operation if the crtc is to be disabled.= In
=A0 =A0this case we merrily swap to the new fb, discarding the old_fb beli= eving
=A0 =A0that it has been cleaned up. However, due to the early return, the<= br> =A0 =A0old_fb was not presented to the backend for correct reaping, and no= r was
=A0 =A0the new one - which is about to be reaped via the
=A0 =A0drm_helper_disable_unused_functions(), leading to incorrect refcoun= ting
=A0 =A0of the pinned objects.

=A0 =A0Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=3D2772= 2
=A0 =A0Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D= 29857
=A0 =A0Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D= 29230
=A0 =A0Tested-by: Takashi Iwai <tiwai@= suse.de>
=A0 =A0Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

--
Chris Wilson, Intel Open Source Technology Centre

Thanks for the prompt reply.

I assume= this will be included in stable?

For the moment I'll just apply= the patch to my build.

Regards,
Pedro
--002215974932540936049bd80b0d-- --===============0655377328== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0655377328==--