From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987Ab1CKTvm (ORCPT ); Fri, 11 Mar 2011 14:51:42 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:49611 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113Ab1CKTvj convert rfc822-to-8bit (ORCPT ); Fri, 11 Mar 2011 14:51:39 -0500 MIME-Version: 1.0 X-Originating-IP: [172.22.72.22] In-Reply-To: <20110310002534.f984f8b2.akpm@linux-foundation.org> References: <1299681411-9227-1-git-send-email-virtuoso@slind.org> <20110309162513.5058c824.akpm@linux-foundation.org> <20110310002534.f984f8b2.akpm@linux-foundation.org> Date: Fri, 11 Mar 2011 11:51:38 -0800 Message-ID: Subject: Re: [RFCv4] timerfd: add TFD_NOTIFY_CLOCK_SET to watch for clock changes From: Scott James Remnant To: Andrew Morton Cc: Alexander Shishkin , linux-kernel@vger.kernel.org, Ken MacLeod , Shaun Reich , Thomas Gleixner , Alexander Viro , Greg Kroah-Hartman , Feng Tang , Michael Tokarev , Marcelo Tosatti , John Stultz , Chris Friesen , Kay Sievers , "Kirill A. Shutemov" , Artem Bityutskiy , Davide Libenzi , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, Michael Kerrisk Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 10, 2011 at 12:25 AM, Andrew Morton wrote: > On Wed, 9 Mar 2011 18:01:09 -0800 Scott James Remnant wrote: > >> > It would be helpful to know if the identified users of this feature >> > actually find it useful and adequate. __I guess the most common >> > application is the 1,001 desktop clock widgets. __Do you have any >> > feedback from any of the owners of those? >> > >> cron is another obvious one (or init systems attempting to replace >> cron). Having to wakeup and check the time every minute can be >> non-conducive to power savings, it would be better if we could just >> sleep until the next alarm and be woken up if the time changes in >> between. >> >> (That being said, we also need to poll for and/or check for timezone >> changes - but those are entirely userspace, so we can deal with that >> separately) > > Sure, there will be lots of applications. > > But what I'm asking isn't "it is a good feature".  I'm asking "is the > feature implemented well".  Ideally someone would get down and modify > cron to use the interface in this patch. > So I've just been thinking today - and I'm actually not sure whether this is needed at all for this case. A good cron implementation is going to set timers according to CLOCK_REALTIME; in the case where the clock changes forwards, those timers will fire as part of the clock changing already no? And in the case where the clock changes backwards, you don't want to re-run old ones anyway. Even the hourly/daily cases are actually at a fixed time, so would be triggered - and a decent implementation wouldn't trigger a given script more than once. I'm going to test this in userspace shortly to see whether it's the case. Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott James Remnant Subject: Re: [RFCv4] timerfd: add TFD_NOTIFY_CLOCK_SET to watch for clock changes Date: Fri, 11 Mar 2011 11:51:38 -0800 Message-ID: References: <1299681411-9227-1-git-send-email-virtuoso@slind.org> <20110309162513.5058c824.akpm@linux-foundation.org> <20110310002534.f984f8b2.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexander Shishkin , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ken MacLeod , Shaun Reich , Thomas Gleixner , Alexander Viro , Greg Kroah-Hartman , Feng Tang , Michael Tokarev , Marcelo Tosatti , John Stultz , Chris Friesen , Kay Sievers , "Kirill A. Shutemov" , Artem Bityutskiy , Davide Libenzi , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michael Kerrisk To: Andrew Morton Return-path: In-Reply-To: <20110310002534.f984f8b2.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Mar 10, 2011 at 12:25 AM, Andrew Morton wrote: > On Wed, 9 Mar 2011 18:01:09 -0800 Scott James Remnant wrote: > >> > It would be helpful to know if the identified users of this featur= e >> > actually find it useful and adequate. __I guess the most common >> > application is the 1,001 desktop clock widgets. __Do you have any >> > feedback from any of the owners of those? >> > >> cron is another obvious one (or init systems attempting to replace >> cron). Having to wakeup and check the time every minute can be >> non-conducive to power savings, it would be better if we could just >> sleep until the next alarm and be woken up if the time changes in >> between. >> >> (That being said, we also need to poll for and/or check for timezone >> changes - but those are entirely userspace, so we can deal with that >> separately) > > Sure, there will be lots of applications. > > But what I'm asking isn't "it is a good feature". =A0I'm asking "is t= he > feature implemented well". =A0Ideally someone would get down and modi= fy > cron to use the interface in this patch. > So I've just been thinking today - and I'm actually not sure whether this is needed at all for this case. A good cron implementation is going to set timers according to CLOCK_REALTIME; in the case where the clock changes forwards, those timers will fire as part of the clock changing already no? And in the case where the clock changes backwards, you don't want to re-run old ones anyway. Even the hourly/daily cases are actually at a fixed time, so would be triggered - and a decent implementation wouldn't trigger a given script more than once. I'm going to test this in userspace shortly to see whether it's the cas= e. Scott