From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754024Ab0HXBUB (ORCPT ); Mon, 23 Aug 2010 21:20:01 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:53459 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125Ab0HXBT7 (ORCPT ); Mon, 23 Aug 2010 21:19:59 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=DWsbDNaAjEtU5uZE3n+CWCAieOdTDFpsOuG1tXTJuihyckuk5NYZNEdGbasQyxb1Pa eZ7nIb//H+Z50eZPBrfmAAB6RGEjMV5epiHMK0MOm2WDFRGdoCDct5YQhPPIjWdLoMGf Koo+lXtPVQS7aGjRbUtkCSYAvJqULPXunLJCY= MIME-Version: 1.0 In-Reply-To: References: <1282580114-2136-1-git-send-email-minchan.kim@gmail.com> <20100823170610.GB2304@barrios-desktop> Date: Tue, 24 Aug 2010 10:19:59 +0900 Message-ID: Subject: Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting From: Minchan Kim To: Christoph Lameter Cc: Andrew Morton , Linux Kernel List , linux-mm@kvack.org, Hugh Dickins , Andi Kleen , Mel Gorman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2010 at 2:17 AM, Christoph Lameter wrote: > On Tue, 24 Aug 2010, Minchan Kim wrote: > >> On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote: >> > On Tue, 24 Aug 2010, Minchan Kim wrote >> > >> > > This patch introude new argument 'cleanup' to migrate_pages. >> > > Only if we set 1 to 'cleanup', migrate_page will clean up the lists. >> > > Otherwise, caller need to clean up the lists so it has a chance to postprocess >> > > the pages. >> > >> > Could we simply make migrate_pages simply not do any cleanup? >> > Caller has to call putback_lru_pages()? >> > >> Hmm. maybe I misunderstood your point. >> Your point is that let's make whole caller of migrate_pagse has a responsibility >> of clean up the list? > > Yes. All callers would be responsible for cleanup. Yes. I hoped it but try to maintain API semantics. But if you agree to change it, I will do it. Will repost. Thanks, Christoph. -- Kind regards, Minchan Kim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 04FC360080F for ; Mon, 23 Aug 2010 21:20:00 -0400 (EDT) Received: by iwn33 with SMTP id 33so5061800iwn.14 for ; Mon, 23 Aug 2010 18:19:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1282580114-2136-1-git-send-email-minchan.kim@gmail.com> <20100823170610.GB2304@barrios-desktop> Date: Tue, 24 Aug 2010 10:19:59 +0900 Message-ID: Subject: Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting From: Minchan Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: Andrew Morton , Linux Kernel List , linux-mm@kvack.org, Hugh Dickins , Andi Kleen , Mel Gorman List-ID: On Tue, Aug 24, 2010 at 2:17 AM, Christoph Lameter wrote: > On Tue, 24 Aug 2010, Minchan Kim wrote: > >> On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote: >> > On Tue, 24 Aug 2010, Minchan Kim wrote >> > >> > > This patch introude new argument 'cleanup' to migrate_pages. >> > > Only if we set 1 to 'cleanup', migrate_page will clean up the lists. >> > > Otherwise, caller need to clean up the lists so it has a chance to postprocess >> > > the pages. >> > >> > Could we simply make migrate_pages simply not do any cleanup? >> > Caller has to call putback_lru_pages()? >> > >> Hmm. maybe I misunderstood your point. >> Your point is that let's make whole caller of migrate_pagse has a responsibility >> of clean up the list? > > Yes. All callers would be responsible for cleanup. Yes. I hoped it but try to maintain API semantics. But if you agree to change it, I will do it. Will repost. Thanks, Christoph. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org