Re: [PATCH V5] powerpc/mpc512x: Add gpio driver

[Grant Likely <grant.likely@secretlab.ca>]

On Wed, Jul 7, 2010 at 5:28 AM, Peter Korsgaard <jacmet@sunsite.dk> wrote:
>>>>>> "Anatolij" =3D=3D Anatolij Gustschin <agust@denx.de> writes:
>
> Hi,
>
> Old mail, I know ..
>
> =A0Anatolij> From: Matthias Fuchs <matthias.fuchs@esd.eu>
> =A0Anatolij> This patch adds a gpio driver for MPC512X PowerPCs.
>
> =A0Anatolij> It has been tested on our CAN-CBX-CPU5201 module that
> =A0Anatolij> uses a MPC5121 CPU. This platform comes with a couple of
> =A0Anatolij> LEDs and configuration switches that have been used for test=
ing.
>
> =A0Anatolij> After change to the of-gpio api the reworked driver has been
> =A0Anatolij> tested on pdm360ng board with some configuration switches.
>
> This looks very similar to the existing
> arch/powerpc/sysdev/mpc8xxx_gpio.c - Couldn't we just add 5121 support
> there instead?
>
> =A0Anatolij> +struct mpc512x_gpio_regs {
> =A0Anatolij> + =A0 =A0u32 gpdir;
> =A0Anatolij> + =A0 =A0u32 gpodr;
> =A0Anatolij> + =A0 =A0u32 gpdat;
> =A0Anatolij> + =A0 =A0u32 gpier;
> =A0Anatolij> + =A0 =A0u32 gpimr;
> =A0Anatolij> + =A0 =A0u32 gpicr1;
> =A0Anatolij> + =A0 =A0u32 gpicr2;
> =A0Anatolij> +};

Hi Anatolij,

Peter's right, the register map looks the same, except for the
additional gpicr1 & 2 registers in the 512x version.  Can the 512x
gpios be supported by the 8xxx gpio driver?

g.