All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Gross <jesse@nicira.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] offloading: Support multiple vlan tags in GSO.
Date: Mon, 1 Nov 2010 18:31:46 -0700	[thread overview]
Message-ID: <AANLkTi=e2kqAmP5pPhQsRHL30Uw8PbZsxz+X8vpJKgWJ@mail.gmail.com> (raw)
In-Reply-To: <1288643630.2231.30.camel@achroite.uk.solarflarecom.com>

On Mon, Nov 1, 2010 at 1:33 PM, Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Fri, 2010-10-29 at 15:14 -0700, Jesse Gross wrote:
>> We assume that hardware TSO can't support multiple levels of vlan tags
>> but we allow it to be done.  Therefore, enable GSO to parse these tags
>> so we can fallback to software.
>>
>> Signed-off-by: Jesse Gross <jesse@nicira.com>
>> CC: Ben Hutchings <bhutchings@solarflare.com>
> [...]
>
> I can't see how TSO would be enabled on a second-level VLAN device;
> presumably you're thinking about GSO being enabled there?

Right, TSO can't be enabled on a stacked vlan device.  However, there
are a few ways that I can think of to hit this code path.  One is GSO,
another is encapsulating a bridged packet that is already tagged.

These are definitely corner cases and I can think of a few other
caveats when using them.  Mostly I'm just thinking about making it
robust in the face of weird corner cases, one piece at a time at
least.

  reply	other threads:[~2010-11-02  1:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 22:14 [PATCH 1/3] offloading: Make scatter/gather more tolerant of vlans Jesse Gross
2010-10-29 22:14 ` [PATCH 2/3] offloading: Support multiple vlan tags in GSO Jesse Gross
2010-11-01 20:33   ` Ben Hutchings
2010-11-02  1:31     ` Jesse Gross [this message]
2010-11-15 17:23   ` David Miller
2010-10-29 22:14 ` [PATCH 3/3] offloading: Force software GSO for multiple vlan tags Jesse Gross
2010-11-15 17:23   ` David Miller
2011-01-07 19:36   ` Michał Mirosław
2011-01-09 16:00     ` Jesse Gross
2010-11-01 20:06 ` [PATCH 1/3] offloading: Make scatter/gather more tolerant of vlans Ben Hutchings
2010-11-15 17:23 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=e2kqAmP5pPhQsRHL30Uw8PbZsxz+X8vpJKgWJ@mail.gmail.com' \
    --to=jesse@nicira.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.