All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Vasiliy G Tolstov <v.tolstov@selfip.ru>
Subject: Re: [GIT PULL] Small Xen bugfixes
Date: Fri, 29 Oct 2010 12:08:09 -0700	[thread overview]
Message-ID: <AANLkTi=g5sdiWSaLUHAATQn-1=jPqtc=RL6SpYSMYn98@mail.gmail.com> (raw)
In-Reply-To: <4CCB1906.4000608@goop.org>

On Fri, Oct 29, 2010 at 11:57 AM, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>    * fix dom0 boot on systems whose E820 doesn't completely cover the
>      ISA address space.  This fixes a crash on a Dell R310.

Hmm. This clashes with my current tree.

And that conflict is trivial to fix up, but the thing is, I think the
patch that comes from your tree is worse than what is already there.

Why is that simple unconditional

    e820_add_region(ISA_START_ADDRESS, ISA_END_ADDRESS - ISA_START_ADDRESS,
           E820_RESERVED);

not just always the right thing? Why do you have a separate hack for
dom0 in xen_release_chunk() instead? That just looks bogus.

The normal logic we use on PC's is to just always reserve the low 64kB
of memory, and the whole ISA space. Why doesn't Xen just do the same?

                          Linus

  reply	other threads:[~2010-10-29 19:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 18:57 [GIT PULL] Small Xen bugfixes Jeremy Fitzhardinge
2010-10-29 18:57 ` Jeremy Fitzhardinge
2010-10-29 19:08 ` Linus Torvalds [this message]
2010-10-29 19:20   ` Jeremy Fitzhardinge
2010-10-29 19:20     ` Jeremy Fitzhardinge
2010-10-29 20:06     ` Jeremy Fitzhardinge
2010-10-31  9:13       ` Ian Campbell
2010-10-31  9:13         ` Ian Campbell
2010-10-31 16:28         ` Jeremy Fitzhardinge
2010-10-31 16:28           ` Jeremy Fitzhardinge
2010-11-01 16:36           ` Ian Campbell
2010-11-01 16:36             ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=g5sdiWSaLUHAATQn-1=jPqtc=RL6SpYSMYn98@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=Xen-devel@lists.xensource.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v.tolstov@selfip.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.