All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tor Arvid Lund <torarvid@gmail.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Is there an updated version of git-vcs-p4?
Date: Mon, 13 Sep 2010 11:04:29 +0200	[thread overview]
Message-ID: <AANLkTi=okJRFeBhbURB8Ez4Vb65fNdacKeko+4sx9ihy@mail.gmail.com> (raw)

Hello, Daniel (and list). I wonder if I might ask you if you have an
"updated" version of git-vcs-p4? Or otherwise, if anyone can hold my
hand while I try to implement what I need... :)

I'm having trouble getting exporting to work. Looking at the C code, I
quickly realize that there's _much_ I don't know anything about, but
it seems to me that vcs-p4.c needs to support the "refspec "
capability. Am I on the right track?

My reasoning so far: the version of vcs-p4.c that I have, contained a
prefixcmp for "export ". This made "git push" barf with the current
version of transport-helper.c, so I did something like this:

diff --git a/vcs-p4/vcs-p4.c b/vcs-p4/vcs-p4.c
index a4613a6..29d761b 100644
--- a/vcs-p4/vcs-p4.c
+++ b/vcs-p4/vcs-p4.c
@@ -1213,7 +1213,18 @@ int main(int argc, const char **argv)
                        }
                        printf("\n");
                        fflush(stdout);
-               } else if (!prefixcmp(buf.buf, "export ")) {
+               } else if (!strcmp(buf.buf, "export")) {
+                       printf("\n"); // no export-marks file
+                       printf("\n"); // no import-marks file either
+                       fflush(stdout);


This got me one step further, but it now produces an empty argument
list to fast-export (in the transport-helper function
push_refs_with_export), because the data->refspecs is NULL. It seems
to get set in get_helper when it encounters the "refspec " cap (which
vcs-p4 does not support).

So - is this "refspec " thingy what needs to be implemented, or am I
lost in space here? :)

-Tor Arvid-

             reply	other threads:[~2010-09-13  9:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13  9:04 Tor Arvid Lund [this message]
2010-09-13 18:53 ` Is there an updated version of git-vcs-p4? Sverre Rabbelier
2010-09-13 20:18   ` Tor Arvid Lund
2010-09-13 21:24 ` Daniel Barkalow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=okJRFeBhbURB8Ez4Vb65fNdacKeko+4sx9ihy@mail.gmail.com' \
    --to=torarvid@gmail.com \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.