All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej Żenczykowski" <zenczykowski@gmail.com>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, eric.dumazet@gmail.com
Subject: Re: [PATCH] Enhance AF_PACKET implementation to not require high order contiguous memory allocation (v2)
Date: Tue, 9 Nov 2010 13:07:32 -0800	[thread overview]
Message-ID: <AANLkTi=s9zr+yF-nr8MoHY6W6m=usR2fH=dPJx6voC34@mail.gmail.com> (raw)
In-Reply-To: <1289324799-2256-1-git-send-email-nhorman@tuxdriver.com>

> +#define PGV_FROM_VMALLOC 1

Why don't we always just use vmalloc, what's the benefit of get_user_pages?

> +       /*
> +        * vmalloc failed, lets dig into swap here
> +        */
> +       *flags = 0;

probably better to *flags &= ~PGV_FROM_VMALLOC;
(since some flags could have been set before this function was called)

> +       gfp_flags &= ~__GFP_NORETRY;
> +       buffer = (char *)__get_free_pages(gfp_flags, order);

wouldn't this still cause problems because you're now requiring linear
memory again?
Would it be better to just fail at this point?

  parent reply	other threads:[~2010-11-09 21:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25 19:06 [PATCH] Enhance AF_PACKET implementation to not require high order contiguous memory allocation nhorman
2010-10-25 20:17 ` Francois Romieu
2010-10-25 20:38 ` Eric Dumazet
2010-11-09 17:46 ` [PATCH] Enhance AF_PACKET implementation to not require high order contiguous memory allocation (v2) nhorman
2010-11-09 18:02   ` Eric Dumazet
2010-11-09 18:38     ` Neil Horman
2010-11-09 19:20       ` Eric Dumazet
2010-11-09 20:57         ` Neil Horman
2010-11-09 21:07   ` Maciej Żenczykowski [this message]
2010-11-09 21:20     ` Neil Horman
2010-11-10 18:20 ` [PATCH] Enhance AF_PACKET implementation to not require high order contiguous memory allocation (v3) nhorman
2010-11-10 18:27   ` Eric Dumazet
2010-11-10 19:09 ` [PATCH] Enhance AF_PACKET implementation to not require high order contiguous memory allocation (v4) nhorman
2010-11-11  6:29   ` Eric Dumazet
2010-11-11  8:03   ` Maciej Żenczykowski
2010-11-16 18:25   ` David Miller
2010-11-16 21:30     ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=s9zr+yF-nr8MoHY6W6m=usR2fH=dPJx6voC34@mail.gmail.com' \
    --to=zenczykowski@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.