From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753364Ab1AYMYR (ORCPT ); Tue, 25 Jan 2011 07:24:17 -0500 Received: from mail-ew0-f46.google.com ([209.85.215.46]:54001 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753315Ab1AYMYP convert rfc822-to-8bit (ORCPT ); Tue, 25 Jan 2011 07:24:15 -0500 MIME-Version: 1.0 In-Reply-To: References: <8yad3nlh18e.fsf@huya.qualcomm.com> <20110125102652.GB11507@n2100.arm.linux.org.uk> Date: Tue, 25 Jan 2011 12:24:13 +0000 Message-ID: Subject: Re: questions about arm trustzone From: Dave Martin To: Santosh Shilimkar Cc: Russell King - ARM Linux , sen wang , David Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 25, 2011 at 11:46 AM, Santosh Shilimkar wrote: >> -----Original Message----- >> From: linux-arm-kernel-bounces@lists.infradead.org [mailto:linux- >> arm-kernel-bounces@lists.infradead.org] On Behalf Of Russell King - >> ARM Linux >> Sent: Tuesday, January 25, 2011 3:57 PM >> To: sen wang >> Cc: David Brown; linux-kernel@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org >> Subject: Re: questions about arm trustzone >> >> On Tue, Jan 25, 2011 at 05:19:16PM +0800, sen wang wrote: >> > It seems linux run in the normal world, and the "scm.c"  is the >> path >> > to the monitor mode. >> > where can I find the example code for monitor and secure world? >> >> OMAP also uses smc: arch/arm/mach-omap2/omap44xx-smc.S >> >> There's no interface defined for smc because it's highly vendor and >> implementation specific.  It's just like a SWI (or svc) where it >> causes entry via a vector into a priviledged mode, which can be >> thought of being similar to a branch to a vector with a mode switch. >> > The code above won't give major details of how the monitor mode is > implemented.  But as Russell said, it's pretty much vendor specific. > > On OMAP, We have standard API interfaces to enter into monitor > world. One of the parameter denotes the kind of service, is > requested. I'm going off on a bit of a tangent here, but do you know whether the Secure World code on OMAP can cope with being called from Thumb? In particular, if the Secure World tries to read the comment field from the SMC instruction (which I notice is non-zero in some cases for OMAP), it would need to be specifically coded to cope with the Thumb case for this to work. Avoiding this complexity is one of the motivations for using r7 for the syscall number with CONFIG_EABI (instead of using the SVC comment field). Currently in my efforts to get the OMAP kernel working in Thumb-2, I have assumed for simplicity that the Secure World will choke on SMCs from Thumb code, but it would be nice to minimise the amount of code which we need to build as ARM in the CONFIG_THUMB2_KERNEL case. In principle, everything could be Thumb code, now that the SWP instruction usage is gone. Cheers ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 From: dave.martin@linaro.org (Dave Martin) Date: Tue, 25 Jan 2011 12:24:13 +0000 Subject: questions about arm trustzone In-Reply-To: References: <8yad3nlh18e.fsf@huya.qualcomm.com> <20110125102652.GB11507@n2100.arm.linux.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jan 25, 2011 at 11:46 AM, Santosh Shilimkar wrote: >> -----Original Message----- >> From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux- >> arm-kernel-bounces at lists.infradead.org] On Behalf Of Russell King - >> ARM Linux >> Sent: Tuesday, January 25, 2011 3:57 PM >> To: sen wang >> Cc: David Brown; linux-kernel at vger.kernel.org; linux-arm- >> kernel at lists.infradead.org >> Subject: Re: questions about arm trustzone >> >> On Tue, Jan 25, 2011 at 05:19:16PM +0800, sen wang wrote: >> > It seems linux run in the normal world, and the "scm.c" ?is the >> path >> > to the monitor mode. >> > where can I find the example code for monitor and secure world? >> >> OMAP also uses smc: arch/arm/mach-omap2/omap44xx-smc.S >> >> There's no interface defined for smc because it's highly vendor and >> implementation specific. ?It's just like a SWI (or svc) where it >> causes entry via a vector into a priviledged mode, which can be >> thought of being similar to a branch to a vector with a mode switch. >> > The code above won't give major details of how the monitor mode is > implemented. ?But as Russell said, it's pretty much vendor specific. > > On OMAP, We have standard API interfaces to enter into monitor > world. One of the parameter denotes the kind of service, is > requested. I'm going off on a bit of a tangent here, but do you know whether the Secure World code on OMAP can cope with being called from Thumb? In particular, if the Secure World tries to read the comment field from the SMC instruction (which I notice is non-zero in some cases for OMAP), it would need to be specifically coded to cope with the Thumb case for this to work. Avoiding this complexity is one of the motivations for using r7 for the syscall number with CONFIG_EABI (instead of using the SVC comment field). Currently in my efforts to get the OMAP kernel working in Thumb-2, I have assumed for simplicity that the Secure World will choke on SMCs from Thumb code, but it would be nice to minimise the amount of code which we need to build as ARM in the CONFIG_THUMB2_KERNEL case. In principle, everything could be Thumb code, now that the SWP instruction usage is gone. Cheers ---Dave