From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60944 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmTTE-0005yH-9F for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:57:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmTTB-0003jp-KT for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:57:44 -0500 Received: from mail-dy0-f45.google.com ([209.85.220.45]:51540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmTTB-0003jc-Eb for qemu-devel@nongnu.org; Mon, 07 Feb 2011 10:57:41 -0500 Received: by dyh23 with SMTP id 23so29166dyh.4 for ; Mon, 07 Feb 2011 07:57:36 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1296497206-15643-2-git-send-email-christophe.lyon@st.com> References: <1296497206-15643-1-git-send-email-christophe.lyon@st.com> <1296497206-15643-2-git-send-email-christophe.lyon@st.com> Date: Mon, 7 Feb 2011 15:57:35 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA. From: Peter Maydell Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: christophe.lyon@st.com Cc: qemu-devel@nongnu.org On 31 January 2011 18:06, wrote: > For variants with rounding, fix cases where adding the rounding > constant could overflow. > > For VSHLL, fix bit mask. These two things are completely distinct -- please put them in separate patches. -- PMM