All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Bruno Randolf <br1@einfach.org>
Cc: bob@bobcopeland.com, ath5k-devel@lists.ath5k.org,
	linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [ath5k-devel] [PATCH 6/8] ath5k: Use common crypt capabilities flags
Date: Sun, 12 Sep 2010 22:35:19 -0400	[thread overview]
Message-ID: <AANLkTik0Ph67jN3od3NAcwwLrQXnpyEqsJU5rfNAJWAJ@mail.gmail.com> (raw)
In-Reply-To: <201009131017.35762.br1@einfach.org>

On Sun, Sep 12, 2010 at 9:17 PM, Bruno Randolf <br1@einfach.org> wrote:
> On Sun September 12 2010 02:27:52 you wrote:
>> On Wed, Sep 08, 2010 at 04:04:59PM +0900, Bruno Randolf wrote:
>> > Replace ah_aes_support and ah_combined_mic with common ath_crypt_caps
>> > ATH_CRYPT_CAP_CIPHER_AESCCM and ATH_CRYPT_CAP_MIC_COMBINED.
>> >
>> > Signed-off-by: Bruno Randolf <br1@einfach.org>
>> >
>> > --- a/drivers/net/wireless/ath/ath5k/base.c
>> > +++ b/drivers/net/wireless/ath/ath5k/base.c
>> > @@ -3298,7 +3298,7 @@ ath5k_set_key(struct ieee80211_hw *hw, enum
>> > set_key_cmd cmd,
>> >
>> >     case WLAN_CIPHER_SUITE_TKIP:
>> >             break;
>> >
>> >     case WLAN_CIPHER_SUITE_CCMP:
>> > -           if (sc->ah->ah_aes_support)
>> > +           if (common->crypt_caps & ATH_CRYPT_CAP_CIPHER_AESCCM)
>> >
>> >                     break;
>> >
>> >             return -EOPNOTSUPP;
>>
>> This could be done by the common code too, right?
>
> yes... ath9k doesn't do this, but i left the old code because i wasn't sure if
> we need it or not. can we sort this out in a following patch?

Yeah, I guess only certain ath5k chipsets do CCMP while all
ath9k ones do..  for sure, follow-up patches are fine for
my minor comments, none of them affect functionality.

-- 
Bob Copeland %% www.bobcopeland.com

  reply	other threads:[~2010-09-13  2:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08  7:04 [PATCH 0/8] ath: Move key cache functions to ath common Bruno Randolf
2010-09-08  7:04 ` [PATCH 1/8] ath: Copy cryptographic capability flags into ath Bruno Randolf
2010-09-08  7:04 ` [PATCH 2/8] ath: Copy key cache management functions from ath9k to ath Bruno Randolf
2010-09-08  7:04 ` [PATCH 3/8] ath5k: Use common ath key management functions Bruno Randolf
2010-09-11 17:22   ` me
2010-09-13  1:09     ` [ath5k-devel] " Bruno Randolf
2010-09-15  2:54       ` Jouni Malinen
2010-09-08  7:04 ` [PATCH 4/8] ath5k: Remove old ath5k key handling functions Bruno Randolf
2010-09-11 17:23   ` bob
2010-09-08  7:04 ` [PATCH 5/8] ath/ath9k: Replace common->splitmic with a flag Bruno Randolf
2010-09-11 17:25   ` bob
2010-09-08  7:04 ` [PATCH 6/8] ath5k: Use common crypt capabilities flags Bruno Randolf
2010-09-11 17:27   ` bob
2010-09-13  1:17     ` Bruno Randolf
2010-09-13  2:35       ` Bob Copeland [this message]
2010-09-08  7:05 ` [PATCH 7/8] ath9k: Use common ath key management functions Bruno Randolf
2010-09-08  7:05 ` [PATCH 8/8] ath9k: Use common crypt capabilities flags Bruno Randolf
2010-09-11 17:31 ` [PATCH 0/8] ath: Move key cache functions to ath common bob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTik0Ph67jN3od3NAcwwLrQXnpyEqsJU5rfNAJWAJ@mail.gmail.com \
    --to=me@bobcopeland.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=bob@bobcopeland.com \
    --cc=br1@einfach.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.