From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Subject: Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept
 FT migration incoming mode.
Date: Sat, 29 Jan 2011 18:31:57 +0900
Message-ID: <AANLkTik0UsAcG7q9+EgEDMvG6XFAwaVzxQ2-iR7T8MST@mail.gmail.com>
References: <1296199312-26334-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
	<1296199312-26334-20-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
	<4D42BD7D.8020004@redhat.com>
	<AANLkTi=Q0R8fcL5M-wdLfoA_6Fwx4QX4mj5sLgSrHCo6@mail.gmail.com>
	<4D42D601.9010905@redhat.com>
	<AANLkTik5tt+o_Sp67TpGw9AZNyMpjK-vyn1VO+SVKo0z@mail.gmail.com>
	<4D42DC5E.8060203@redhat.com>
	<AANLkTimaAqcFipREj+XOdprfoL=Sy_nu=_=cjbjJZFD2@mail.gmail.com>
	<4D42E37B.9010207@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kwolf@redhat.com, aliguori@us.ibm.com, dlaor@redhat.com,
	ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
	mtosatti@redhat.com, qemu-devel@nongnu.org,
	vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com,
	ohmura.kei@lab.ntt.co.jp, avi@redhat.com,
	psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:35762 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751298Ab1A2JcA convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Sat, 29 Jan 2011 04:32:00 -0500
Received: by wyb28 with SMTP id 28so4005181wyb.19
        for <kvm@vger.kernel.org>; Sat, 29 Jan 2011 01:31:58 -0800 (PST)
In-Reply-To: <4D42E37B.9010207@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2011/1/29 Paolo Bonzini <pbonzini@redhat.com>:
> On 01/28/2011 04:31 PM, Yoshiaki Tamura wrote:
>>
>> That's the hack I was imaging:)
>
> So your original patch is also a hack? :)

TBH, yeah :) I didn't came up better idea that is not over
engineered.

>> Maybe this is just an issue of preference, but I'm not sure
>> adding "kemari:" to be intuitive. =A0If there were similar
>> extensions having the same problem, I would have agreed quickly.
>> I originally didn't have this idea, but simply adding -kemari
>> separate from -incoming isn't enough?
>
> No idea... =A0Only, having "migrate" on one side and something other =
than
> "-incoming" on the other side seems strange.

OK, then while keeping "-incoming kemari:tcp:<host>:<port>" as a
strong solution, could you please explain why placing the original
parser under tcp handler wasn't a good idea?  With that,
-incoming exec .*,ft_mode shouldn't be a problem.  I
chose "-incoming tcp:<host>:<port>, ft_mode" because qemu usually
take "," for specifying variants for each option (e.g. -net
nic,macaddr=3D).  The problem was -incoming didn't have it yet.

Yoshi

>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html
>

From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40612 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pj7A1-0003aO-Lm
	for qemu-devel@nongnu.org; Sat, 29 Jan 2011 04:32:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tamura.yoshiaki@gmail.com>) id 1Pj7A0-0002Hy-DF
	for qemu-devel@nongnu.org; Sat, 29 Jan 2011 04:32:01 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:49472)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tamura.yoshiaki@gmail.com>) id 1Pj7A0-0002Hj-9C
	for qemu-devel@nongnu.org; Sat, 29 Jan 2011 04:32:00 -0500
Received: by wyg36 with SMTP id 36so4107596wyg.4
	for <qemu-devel@nongnu.org>; Sat, 29 Jan 2011 01:31:58 -0800 (PST)
MIME-Version: 1.0
Sender: tamura.yoshiaki@gmail.com
In-Reply-To: <4D42E37B.9010207@redhat.com>
References: <1296199312-26334-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
	<1296199312-26334-20-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
	<4D42BD7D.8020004@redhat.com>
	<AANLkTi=Q0R8fcL5M-wdLfoA_6Fwx4QX4mj5sLgSrHCo6@mail.gmail.com>
	<4D42D601.9010905@redhat.com>
	<AANLkTik5tt+o_Sp67TpGw9AZNyMpjK-vyn1VO+SVKo0z@mail.gmail.com>
	<4D42DC5E.8060203@redhat.com>
	<AANLkTimaAqcFipREj+XOdprfoL=Sy_nu=_=cjbjJZFD2@mail.gmail.com>
	<4D42E37B.9010207@redhat.com>
Date: Sat, 29 Jan 2011 18:31:57 +0900
Message-ID: <AANLkTik0UsAcG7q9+EgEDMvG6XFAwaVzxQ2-iR7T8MST@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept
	FT migration incoming mode.
From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com

2011/1/29 Paolo Bonzini <pbonzini@redhat.com>:
> On 01/28/2011 04:31 PM, Yoshiaki Tamura wrote:
>>
>> That's the hack I was imaging:)
>
> So your original patch is also a hack? :)

TBH, yeah :) I didn't came up better idea that is not over
engineered.

>> Maybe this is just an issue of preference, but I'm not sure
>> adding "kemari:" to be intuitive. =A0If there were similar
>> extensions having the same problem, I would have agreed quickly.
>> I originally didn't have this idea, but simply adding -kemari
>> separate from -incoming isn't enough?
>
> No idea... =A0Only, having "migrate" on one side and something other than
> "-incoming" on the other side seems strange.

OK, then while keeping "-incoming kemari:tcp:<host>:<port>" as a
strong solution, could you please explain why placing the original
parser under tcp handler wasn't a good idea?  With that,
-incoming exec .*,ft_mode shouldn't be a problem.  I
chose "-incoming tcp:<host>:<port>, ft_mode" because qemu usually
take "," for specifying variants for each option (e.g. -net
nic,macaddr=3D).  The problem was -incoming didn't have it yet.

Yoshi

>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html
>