Re: [PATCH] Btrfs-progs use safe string manipulation functions

From: Olaf van der Spek <olafvdspek@gmail.com>
To: Eduardo Silva <eduardo.silva@oracle.com>
Cc: Jeremy Sanders <jeremy@jeremysanders.net>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs-progs use safe string manipulation functions
Date: Thu, 10 Feb 2011 14:34:57 +0100	[thread overview]
Message-ID: <AANLkTik0stPo-_s-n8ndZUiwYcZ51V6m29x1X56q8AYd@mail.gmail.com> (raw)
In-Reply-To: <1297344585.28159.12.camel@monotop>

On Thu, Feb 10, 2011 at 2:29 PM, Eduardo Silva <eduardo.silva@oracle.co=
m> wrote:
>> > There's strlcpy, but it's not in glibc because of possible truncat=
ion
>> > errors!
>>
>> Then use a private wrapper.
>>
>
> Here's the new patch:
>
> ----
> [PATCH] Add safe string manipulation functions
>
> Deprecate direct use of strcpy(3)
> The following string manipulation function has been added:
>
> =C2=A0 - string_copy() : wrapper of strcpy(3)
> =C2=A0 - string_ncopy(): wrapper of strncpy(3)
>
> both function compose safe NULL terminated strings.
> ----
>
> I check that the code most of the time raise an error if the path is =
too
> long, so the new wrappers should be ok...

string_copy seems pointless, it's kinda equivalent to strcpy.
if (!dest || !src) should include an assert so it's easier to break in
the debugger.

--=20
Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html