From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: Add a reset interface Date: Mon, 31 Jan 2011 06:03:25 +1000 Message-ID: References: <1295884531-600-1-git-send-email-chris@chris-wilson.co.uk> <1bdc18$jeakgc@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-qy0-f170.google.com (mail-qy0-f170.google.com [209.85.216.170]) by gabe.freedesktop.org (Postfix) with ESMTP id B2A619E746 for ; Sun, 30 Jan 2011 12:03:26 -0800 (PST) Received: by qyk10 with SMTP id 10so2843178qyk.15 for ; Sun, 30 Jan 2011 12:03:26 -0800 (PST) In-Reply-To: <1bdc18$jeakgc@fmsmga002.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: tiwai@suse.de, mat@mshopf.de, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sun, Jan 30, 2011 at 9:50 PM, Chris Wilson wr= ote: > On Mon, 24 Jan 2011 15:55:27 +0000, Chris Wilson wrote: >> For i915 there is a need to invalidate some cached state after resuming = or >> reseting the GPU. This is not quite the same as simply restoring saved >> state (i.e. the standard suspend resume method), so do not seem to merit >> reusing the save|restore vfuncs. =A0Instead I propose a >> >> =A0 =A0drm_mode_config_reset(struct drm_device *); >> >> routine to iterate over all the attached CRTCs, encoders and connectors >> and call any supplied reset vfunc. >> >> This is required to fix some modesetting regressions across resume in >> 2.6.38: >> https://bugzilla.kernel.org/show_bug.cgi?id=3D26952 >> https://bugzilla.kernel.org/show_bug.cgi?id=3D27272 > > Dave, what's your take on adding a new (crtc|encoder|connector)->reset() > vfunc to drm core? Do I need to code up an Intel specific alternative? It seems like an interface we could use, I just wasn't sure how a regressio= n fix for something in. 38 isn't a revert but requires a whole new interface in the core drm to fix. Perhaps if you can enlighten me on that I'd be happier. Dave.