From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934990Ab0KQRCk (ORCPT ); Wed, 17 Nov 2010 12:02:40 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:42293 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932743Ab0KQRCj convert rfc822-to-8bit (ORCPT ); Wed, 17 Nov 2010 12:02:39 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=eUHY7tNYJU8Gk4Dov1eRVPMb24DT4J7cQFC7XkeNw/R0zH/k3AQ6BCOT3lG49CPqBh 1ESUvS5cHWOWbUEAJ8+bPHLd7OwjXJxGSB7cYyWqRAGa7d7QP4mf1MXvk+81TlGuTEoF Wm6+JLRgSJEpSTlQVU026uDoA5StMkHKfwOxI= MIME-Version: 1.0 In-Reply-To: <20101115183014.GD31421@n2100.arm.linux.org.uk> References: <1289584840-18097-1-git-send-email-catalin.marinas@arm.com> <1289584840-18097-6-git-send-email-catalin.marinas@arm.com> <20101115183014.GD31421@n2100.arm.linux.org.uk> Date: Wed, 17 Nov 2010 17:02:37 +0000 X-Google-Sender-Auth: 2Sd3cM5Jvyic-faZCOsWRaVxDw8 Message-ID: Subject: Re: [PATCH v2 05/20] ARM: LPAE: Introduce L_PTE_NOEXEC and L_PTE_NOWRITE From: Catalin Marinas To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15 November 2010 18:30, Russell King - ARM Linux wrote: > On Fri, Nov 12, 2010 at 06:00:25PM +0000, Catalin Marinas wrote: >> --- a/arch/arm/include/asm/pgtable-2level.h >> +++ b/arch/arm/include/asm/pgtable-2level.h >> @@ -128,6 +128,8 @@ >>  #define L_PTE_USER           (1 << 8) >>  #define L_PTE_EXEC           (1 << 9) >>  #define L_PTE_SHARED         (1 << 10)       /* shared(v6), coherent(xsc3) */ >> +#define L_PTE_NOEXEC         (0) >> +#define L_PTE_NOWRITE                (0) > > Let's not make this more complicated than it has to be.  If we need the > inverse of WRITE and EXEC, then that's what we should change everyone to, > not invent a new system to work along side the old system. Question on the pgprot_noncached/writecombine/dmacoherent - in the current implementation we pass L_PTE_EXEC on the dmacoherent macro. Do we need to pass L_PTE_NOEXEC to the noncached/writecombine ones? I don't see a reason for any of these to be executable but maybe we can let the code calling them decide. Thanks. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Wed, 17 Nov 2010 17:02:37 +0000 Subject: [PATCH v2 05/20] ARM: LPAE: Introduce L_PTE_NOEXEC and L_PTE_NOWRITE In-Reply-To: <20101115183014.GD31421@n2100.arm.linux.org.uk> References: <1289584840-18097-1-git-send-email-catalin.marinas@arm.com> <1289584840-18097-6-git-send-email-catalin.marinas@arm.com> <20101115183014.GD31421@n2100.arm.linux.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 15 November 2010 18:30, Russell King - ARM Linux wrote: > On Fri, Nov 12, 2010 at 06:00:25PM +0000, Catalin Marinas wrote: >> --- a/arch/arm/include/asm/pgtable-2level.h >> +++ b/arch/arm/include/asm/pgtable-2level.h >> @@ -128,6 +128,8 @@ >> ?#define L_PTE_USER ? ? ? ? ? (1 << 8) >> ?#define L_PTE_EXEC ? ? ? ? ? (1 << 9) >> ?#define L_PTE_SHARED ? ? ? ? (1 << 10) ? ? ? /* shared(v6), coherent(xsc3) */ >> +#define L_PTE_NOEXEC ? ? ? ? (0) >> +#define L_PTE_NOWRITE ? ? ? ? ? ? ? ?(0) > > Let's not make this more complicated than it has to be. ?If we need the > inverse of WRITE and EXEC, then that's what we should change everyone to, > not invent a new system to work along side the old system. Question on the pgprot_noncached/writecombine/dmacoherent - in the current implementation we pass L_PTE_EXEC on the dmacoherent macro. Do we need to pass L_PTE_NOEXEC to the noncached/writecombine ones? I don't see a reason for any of these to be executable but maybe we can let the code calling them decide. Thanks. -- Catalin