From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55215 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGxcC-0008UZ-FJ
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 12:40:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PGxcB-0003Cz-5J
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 12:40:44 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:53990)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PGxcA-0003Cd-Vu
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 12:40:43 -0500
Received: by wwe15 with SMTP id 15so2618519wwe.10
	for <qemu-devel@nongnu.org>; Fri, 12 Nov 2010 09:40:42 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4CDD78D9.8090909@redhat.com>
References: <1288263684-18892-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1288263684-18892-4-git-send-email-stefanha@linux.vnet.ibm.com>
	<4CDD78D9.8090909@redhat.com>
Date: Fri, 12 Nov 2010 17:40:41 +0000
Message-ID: <AANLkTik68QJqnV4rptaiMo=McCNszhgSiFAdRJgpa3Nj@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH v4 3/5] qed: Table, L2 cache,
	and cluster functions
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>, Avi Kivity <avi@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Christoph Hellwig <hch@lst.de>

On Fri, Nov 12, 2010 at 5:26 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 28.10.2010 13:01, schrieb Stefan Hajnoczi:
>> This patch adds code to look up data cluster offsets in the image via
>> the L1/L2 tables. =A0The L2 tables are writethrough cached in memory for
>> performance (each read/write requires a lookup so it is essential to
>> cache the tables).
>>
>> With cluster lookup code in place it is possible to implement
>> bdrv_is_allocated() to query the number of contiguous
>> allocated/unallocated clusters.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>
> Didn't find any obvious problems with this one, but maybe that just
> means that I'm tired and should stop working for today. ;-)

Thanks for your review effort, Kevin.

Stefan