Re: [PATCH] fetch: don't output non-errors on stderr

From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] fetch: don't output non-errors on stderr
Date: Sat, 26 Jun 2010 12:14:59 +0000	[thread overview]
Message-ID: <AANLkTik6jbcOtyXJ5JJav1xnLEO6RSmYTHpsX6yYaB5_@mail.gmail.com> (raw)
In-Reply-To: <20100626061305.GB10290@coredump.intra.peff.net>

On Sat, Jun 26, 2010 at 06:13, Jeff King <peff@peff.net> wrote:

> Or even easier: is there a reason that "git fetch -q" would not do what
> you (Ævar) want?

That'd reduce the verbosity level, which'd skip some messages that I
might want. E.g.:

		if (verbosity >= 0) {
			fprintf(stderr, " x %-*s %-*s -> %s\n",
				TRANSPORT_SUMMARY_WIDTH, "[deleted]",
				REFCOL_WIDTH, "(none)", prettify_refname(ref->name));

Anyway, it looks like the only correct way to do this with Git in
general is to:

    1. Capture stderr and stdout
    2. Check the exit code, and if it's non-zero print both

But it sounds like we need some general discussion on what stdout and
stderr should be used for in Git with regards to progress messages,
errors and other similar things.