From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Gardiner <bengardiner@nanometrics.ca>
Date: Thu, 23 Sep 2010 09:24:03 -0400
Subject: [U-Boot] [PATCH v4 1/2][NEXT] davinci_emac:
	davinci_eth_set_mac_addr to ->write_hwaddr
In-Reply-To: <4C9B17D9.6020700@ge.com>
References: <cover.1285175583.git.bengardiner@nanometrics.ca>
	<cover.1285180933.git.bengardiner@nanometrics.ca>
	<d13a16f23dd9891f49916c13b983389ed659f8c7.1285180933.git.bengardiner@nanometrics.ca>
	<4C9B17D9.6020700@ge.com>
Message-ID: <AANLkTik9n9Vg7b0QgMJ1HTGOXNUqn6=D-O5OG=moYDOi@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, Sep 23, 2010 at 5:03 AM, Nick Thompson <nick.thompson@ge.com> wrote:
> davinci_eth_set_mac_addr() always returns zero, so "if (!dev->write_hwaddr(dev))"
> always appears to fail here.
>
> In net/eth.c the return code is not checked, so da830 should probably ignore it to:

You're absolutely right, Nick. Thanks for the review and testing; patch coming.

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca