From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:61736 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754873Ab0INTcX convert rfc822-to-8bit (ORCPT ); Tue, 14 Sep 2010 15:32:23 -0400 MIME-Version: 1.0 In-Reply-To: <20100914192738.GB21918@void.printf.net> References: <1283858949-11073-1-git-send-email-ohad@wizery.com> <1283858949-11073-8-git-send-email-ohad@wizery.com> <20100914192738.GB21918@void.printf.net> From: Ohad Ben-Cohen Date: Tue, 14 Sep 2010 21:32:01 +0200 Message-ID: Subject: Re: [PATCH v1 7/8] sdio: enable Runtime PM for SDIO functions To: Chris Ball Cc: linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org, Luciano Coelho , akpm@linux-foundation.org, San Mehat , Roger Quadros , Nicolas Pitre , Gao Yunpeng Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Chris, On Tue, Sep 14, 2010 at 9:27 PM, Chris Ball wrote: > On Tue, Sep 07, 2010 at 02:29:08PM +0300, Ohad Ben-Cohen wrote: > > @@ -152,6 +173,11 @@ static int sdio_bus_remove(struct device *dev) > >               sdio_release_host(func); > >       } > > > > +     pm_runtime_put_noidle(dev); > > + > > +     /* Undo the runtime PM settings in sdio_bus_probe() */ > > +     pm_runtime_put_noidle(dev); > > + > >       return 0; > >  } > > > > Nit:  This makes sense in context, but stands out as a possible paste > accident on first sight.  :)  I think it's worth adding a comment to > the first call Will do, thanks for the review! Ohad. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ohad Ben-Cohen Subject: Re: [PATCH v1 7/8] sdio: enable Runtime PM for SDIO functions Date: Tue, 14 Sep 2010 21:32:01 +0200 Message-ID: References: <1283858949-11073-1-git-send-email-ohad@wizery.com> <1283858949-11073-8-git-send-email-ohad@wizery.com> <20100914192738.GB21918@void.printf.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20100914192738.GB21918-zkTaxWjgBN6ccd+RBA7C9g@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chris Ball Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Luciano Coelho , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, San Mehat , Roger Quadros , Nicolas Pitre , Gao Yunpeng List-Id: linux-mmc@vger.kernel.org Hi Chris, On Tue, Sep 14, 2010 at 9:27 PM, Chris Ball wrote: > On Tue, Sep 07, 2010 at 02:29:08PM +0300, Ohad Ben-Cohen wrote: > > @@ -152,6 +173,11 @@ static int sdio_bus_remove(struct device *dev) > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 sdio_release_host(func); > > =A0 =A0 =A0 } > > > > + =A0 =A0 pm_runtime_put_noidle(dev); > > + > > + =A0 =A0 /* Undo the runtime PM settings in sdio_bus_probe() */ > > + =A0 =A0 pm_runtime_put_noidle(dev); > > + > > =A0 =A0 =A0 return 0; > > =A0} > > > > Nit: =A0This makes sense in context, but stands out as a possible pas= te > accident on first sight. =A0:) =A0I think it's worth adding a comment= to > the first call Will do, thanks for the review! Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html