From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34359 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJ1MC-0007Rk-Q8
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 05:04:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PJ1M4-0000Zz-Uz
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 05:04:42 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:52118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PJ1M4-0000Zp-PY
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 05:04:36 -0500
Received: by wyj26 with SMTP id 26so3164999wyj.4
	for <qemu-devel@nongnu.org>; Thu, 18 Nov 2010 02:04:36 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1289870175-14880-3-git-send-email-mdroth@linux.vnet.ibm.com>
References: <1289870175-14880-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1289870175-14880-3-git-send-email-mdroth@linux.vnet.ibm.com>
Date: Thu, 18 Nov 2010 10:04:35 +0000
Message-ID: <AANLkTikAVksadt-jDd-hX-exf4DJ+xrMrSPaZNXR0W07@mail.gmail.com>
Subject: Re: [Qemu-devel] [RFC][PATCH v3 02/21] virtproxy: qemu-vp, standalone
	daemon skeleton
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, amit.shah@redhat.com

On Tue, Nov 16, 2010 at 1:15 AM, Michael Roth <mdroth@linux.vnet.ibm.com> w=
rote:
> Daemon to be run in guest, or on host in standalone mode.
> (re-)implements some qemu utility functions used by core virtproxy.c
> code via wrapper functions. For built-in virtproxy code we will define
> these wrapper functions in terms of qemu's built-in implementations.
>
> Main logic will come in a later patch.
>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
> =A0qemu-vp.c | =A0151 +++++++++++++++++++++++++++++++++++++++++++++++++++=
++++++++++
> =A01 files changed, 151 insertions(+), 0 deletions(-)
> =A0create mode 100644 qemu-vp.c

Can you move IOHandlerRecord, main_loop_wait(), and friends out of
vl.c and into a portable self-contained file that can be used both
from qemu and virtproxy?

Also, check out 0290b57bdfec83ca78b6d119ea9847bb17943328 which fixes a
main_loo_wait() bug.  It was recently committed and didn't make it
into qemu-vp.c.

It would be unfortunate to duplicate this code.

Stefan