From mboxrd@z Thu Jan 1 00:00:00 1970 From: Blue Swirl Subject: Re: [PATCH 0/7] AMD IOMMU emulation patchset v4 Date: Sat, 28 Aug 2010 16:00:31 +0000 Message-ID: References: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: mst@redhat.com, joro@8bytes.org, paul@codesourcery.com, avi@redhat.com, anthony@codemonkey.ws, av1474@comtv.ru, yamahata@valinux.co.jp, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Eduard - Gabriel Munteanu Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:54681 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500Ab0H1QAw convert rfc822-to-8bit (ORCPT ); Sat, 28 Aug 2010 12:00:52 -0400 Received: by qwh6 with SMTP id 6so3708495qwh.19 for ; Sat, 28 Aug 2010 09:00:51 -0700 (PDT) In-Reply-To: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Aug 28, 2010 at 2:54 PM, Eduard - Gabriel Munteanu wrote: > Hi, > > I rebased my work on mst's PCI tree and, hopefully, fixed issues rais= ed by > others. Here's a summary of the changes: > - made it apply to mst/pci > - moved some AMD IOMMU stuff in a reset handler > - dropped range_covers_range() (wasn't the same as ranges_overlap(), = but the > =C2=A0latter was better anyway) > - used 'expand' to remove tabs in pci_regs.h before applying the usef= ul changes > - fixed the endianness mistake spotted by Blue (though ldq_phys wasn'= t needed) > > As for Anthony's suggestion to simply sed-convert all devices, I'd ra= ther go > through them one at a time and do it manually. 'sed' would not only m= ess > indentation, but also it isn't straightforward to get the 'PCIDevice = *' you > need to pass to the pci_* helpers. (I'll try to focus on conversion n= ext so we > can poison the old stuff.) > > I also added (read "spelled it out myself") malc's ACK to the ac97 pa= tch. > Nothing changed since his last review. > > Please have a look and merge if you like it. The endianess bug still exists. I had also other comments to 2. > > > =C2=A0 =C2=A0Thanks, > =C2=A0 =C2=A0Eduard > > > Eduard - Gabriel Munteanu (7): > =C2=A0pci: expand tabs to spaces in pci_regs.h > =C2=A0pci: memory access API and IOMMU support > =C2=A0AMD IOMMU emulation > =C2=A0ide: use the PCI memory access interface > =C2=A0rtl8139: use the PCI memory access interface > =C2=A0eepro100: use the PCI memory access interface > =C2=A0ac97: use the PCI memory access interface > > =C2=A0Makefile.target =C2=A0 =C2=A0| =C2=A0 =C2=A02 +- > =C2=A0dma-helpers.c =C2=A0 =C2=A0 =C2=A0| =C2=A0 46 ++- > =C2=A0dma.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 = 21 +- > =C2=A0hw/ac97.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A06 +- > =C2=A0hw/amd_iommu.c =C2=A0 =C2=A0 | =C2=A0663 ++++++++++++++++++++++= ++++ > =C2=A0hw/eepro100.c =C2=A0 =C2=A0 =C2=A0| =C2=A0 86 ++-- > =C2=A0hw/ide/core.c =C2=A0 =C2=A0 =C2=A0| =C2=A0 15 +- > =C2=A0hw/ide/internal.h =C2=A0| =C2=A0 39 ++ > =C2=A0hw/ide/macio.c =C2=A0 =C2=A0 | =C2=A0 =C2=A04 +- > =C2=A0hw/ide/pci.c =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A07 + > =C2=A0hw/pc.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A0= 2 + > =C2=A0hw/pci.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0185 +++++++= +- > =C2=A0hw/pci.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 74 +++ > =C2=A0hw/pci_ids.h =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A02 + > =C2=A0hw/pci_internals.h | =C2=A0 12 + > =C2=A0hw/pci_regs.h =C2=A0 =C2=A0 =C2=A0| 1331 ++++++++++++++++++++++= ++++-------------------------- > =C2=A0hw/rtl8139.c =C2=A0 =C2=A0 =C2=A0 | =C2=A0 99 +++-- > =C2=A0qemu-common.h =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A01 + > =C2=A018 files changed, 1827 insertions(+), 768 deletions(-) > =C2=A0create mode 100644 hw/amd_iommu.c > =C2=A0rewrite hw/pci_regs.h (90%) > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60253 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OpNpx-0001VM-8Z for qemu-devel@nongnu.org; Sat, 28 Aug 2010 12:01:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OpNps-00009S-1m for qemu-devel@nongnu.org; Sat, 28 Aug 2010 12:00:54 -0400 Received: from mail-qy0-f173.google.com ([209.85.216.173]:56978) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OpNpr-00009O-Ue for qemu-devel@nongnu.org; Sat, 28 Aug 2010 12:00:51 -0400 Received: by qyk5 with SMTP id 5so1716859qyk.4 for ; Sat, 28 Aug 2010 09:00:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> References: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> From: Blue Swirl Date: Sat, 28 Aug 2010 16:00:31 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 0/7] AMD IOMMU emulation patchset v4 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduard - Gabriel Munteanu Cc: kvm@vger.kernel.org, mst@redhat.com, joro@8bytes.org, qemu-devel@nongnu.org, yamahata@valinux.co.jp, avi@redhat.com, paul@codesourcery.com On Sat, Aug 28, 2010 at 2:54 PM, Eduard - Gabriel Munteanu wrote: > Hi, > > I rebased my work on mst's PCI tree and, hopefully, fixed issues raised b= y > others. Here's a summary of the changes: > - made it apply to mst/pci > - moved some AMD IOMMU stuff in a reset handler > - dropped range_covers_range() (wasn't the same as ranges_overlap(), but = the > =C2=A0latter was better anyway) > - used 'expand' to remove tabs in pci_regs.h before applying the useful c= hanges > - fixed the endianness mistake spotted by Blue (though ldq_phys wasn't ne= eded) > > As for Anthony's suggestion to simply sed-convert all devices, I'd rather= go > through them one at a time and do it manually. 'sed' would not only mess > indentation, but also it isn't straightforward to get the 'PCIDevice *' y= ou > need to pass to the pci_* helpers. (I'll try to focus on conversion next = so we > can poison the old stuff.) > > I also added (read "spelled it out myself") malc's ACK to the ac97 patch. > Nothing changed since his last review. > > Please have a look and merge if you like it. The endianess bug still exists. I had also other comments to 2. > > > =C2=A0 =C2=A0Thanks, > =C2=A0 =C2=A0Eduard > > > Eduard - Gabriel Munteanu (7): > =C2=A0pci: expand tabs to spaces in pci_regs.h > =C2=A0pci: memory access API and IOMMU support > =C2=A0AMD IOMMU emulation > =C2=A0ide: use the PCI memory access interface > =C2=A0rtl8139: use the PCI memory access interface > =C2=A0eepro100: use the PCI memory access interface > =C2=A0ac97: use the PCI memory access interface > > =C2=A0Makefile.target =C2=A0 =C2=A0| =C2=A0 =C2=A02 +- > =C2=A0dma-helpers.c =C2=A0 =C2=A0 =C2=A0| =C2=A0 46 ++- > =C2=A0dma.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 21 += - > =C2=A0hw/ac97.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A06 +- > =C2=A0hw/amd_iommu.c =C2=A0 =C2=A0 | =C2=A0663 ++++++++++++++++++++++++++ > =C2=A0hw/eepro100.c =C2=A0 =C2=A0 =C2=A0| =C2=A0 86 ++-- > =C2=A0hw/ide/core.c =C2=A0 =C2=A0 =C2=A0| =C2=A0 15 +- > =C2=A0hw/ide/internal.h =C2=A0| =C2=A0 39 ++ > =C2=A0hw/ide/macio.c =C2=A0 =C2=A0 | =C2=A0 =C2=A04 +- > =C2=A0hw/ide/pci.c =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A07 + > =C2=A0hw/pc.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A02 + > =C2=A0hw/pci.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0185 ++++++++- > =C2=A0hw/pci.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 74 +++ > =C2=A0hw/pci_ids.h =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A02 + > =C2=A0hw/pci_internals.h | =C2=A0 12 + > =C2=A0hw/pci_regs.h =C2=A0 =C2=A0 =C2=A0| 1331 ++++++++++++++++++++++++++= -------------------------- > =C2=A0hw/rtl8139.c =C2=A0 =C2=A0 =C2=A0 | =C2=A0 99 +++-- > =C2=A0qemu-common.h =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A01 + > =C2=A018 files changed, 1827 insertions(+), 768 deletions(-) > =C2=A0create mode 100644 hw/amd_iommu.c > =C2=A0rewrite hw/pci_regs.h (90%) > >