From: Po-Yu Chuang <ratbert.chuang@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Po-Yu Chuang <ratbert@faraday-tech.com>
Subject: Re: [PATCH] net: add Faraday FTMAC100 10/100 Ethernet driver
Date: Fri, 14 Jan 2011 14:49:45 +0800 [thread overview]
Message-ID: <AANLkTikP1T9XXPVNHnmPnamjwyF5nNn+hVvpovAxTx69@mail.gmail.com> (raw)
In-Reply-To: <1294959948.4114.189.camel@Joe-Laptop>
Dear Joe,
On Fri, Jan 14, 2011 at 7:05 AM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2011-01-13 at 19:49 +0800, Po-Yu Chuang wrote:
>> From: Po-Yu Chuang <ratbert@faraday-tech.com>
> []
>> + if (is_zero_ether_addr(netdev->dev_addr)) {
>> + random_ether_addr(netdev->dev_addr);
>> + dev_info(&netdev->dev, "generated random MAC address "
>> + "%.2x:%.2x:%.2x:%.2x:%.2x:%.2x.\n",
>> + netdev->dev_addr[0], netdev->dev_addr[1],
>> + netdev->dev_addr[2], netdev->dev_addr[3],
>> + netdev->dev_addr[4], netdev->dev_addr[5]);
>
> Sorry, one other thing.
> There are kernel specific printf extensions for pointer types.
> (look at lib/vsprintf.c) There's one for mac addresses: "%pM".
> This could be done as:
>
> netdev_info(netdev, "Generated random MAC address: %pM\n",
> netdev->dev_addr);
Wow, this is pretty beautiful. Thanks.
best regards,
Po-Yu Chuang
next prev parent reply other threads:[~2011-01-14 6:50 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 11:49 [PATCH] net: add Faraday FTMAC100 10/100 Ethernet driver Po-Yu Chuang
2011-01-13 14:03 ` Ben Hutchings
2011-01-14 5:37 ` Po-Yu Chuang
2011-01-13 14:22 ` Eric Dumazet
2011-01-13 16:29 ` Andres Salomon
2011-01-14 6:44 ` Po-Yu Chuang
2011-01-14 6:56 ` Po-Yu Chuang
2011-01-13 15:39 ` Joe Perches
2011-01-14 6:35 ` Po-Yu Chuang
[not found] ` <1294959948.4114.189.camel@Joe-Laptop>
2011-01-14 6:49 ` Po-Yu Chuang [this message]
2011-01-17 9:21 ` [PATCH v2] " Po-Yu Chuang
2011-01-17 17:19 ` Joe Perches
2011-01-19 9:40 ` Po-Yu Chuang
2011-01-19 12:46 ` Ben Hutchings
2011-01-19 16:41 ` Joe Perches
2011-01-20 5:30 ` Po-Yu Chuang
2011-01-20 8:46 ` Joe Perches
2011-01-17 17:29 ` Eric Dumazet
2011-01-17 18:58 ` Ben Hutchings
2011-01-17 20:39 ` Eric Dumazet
2011-01-17 18:21 ` Eric Dumazet
2011-01-18 3:08 ` Po-Yu Chuang
2011-01-19 9:20 ` Po-Yu Chuang
2011-01-20 15:30 ` [PATCH v3] " Po-Yu Chuang
2011-01-20 15:35 ` Eric Dumazet
2011-01-20 15:43 ` Po-Yu Chuang
2011-01-20 15:41 ` Eric Dumazet
2011-01-20 15:54 ` Po-Yu Chuang
2011-01-20 17:56 ` Joe Perches
2011-01-21 3:35 ` Po-Yu Chuang
2011-01-20 19:00 ` Joe Perches
2011-01-21 5:03 ` Po-Yu Chuang
[not found] ` <1295592411.6795.10.camel@Joe-Laptop>
2011-01-21 7:06 ` Po-Yu Chuang
2011-01-20 19:01 ` Michał Mirosław
2011-01-21 3:37 ` Po-Yu Chuang
2011-01-21 7:55 ` [PATCH v4] " Po-Yu Chuang
2011-01-21 9:08 ` Eric Dumazet
2011-01-24 8:07 ` Po-Yu Chuang
2011-01-21 12:26 ` Michał Mirosław
2011-01-24 8:26 ` Po-Yu Chuang
2011-01-24 20:22 ` Michał Mirosław
2011-01-25 2:46 ` Po-Yu Chuang
2011-02-01 3:56 ` Po-Yu Chuang
2011-02-01 4:35 ` David Miller
2011-02-24 7:27 ` Po-Yu Chuang
2011-02-24 7:51 ` David Miller
2011-02-24 8:07 ` Po-Yu Chuang
2011-02-24 8:22 ` Eric Dumazet
2011-02-24 9:29 ` [PATCH ref0] " Po-Yu Chuang
2011-02-24 17:39 ` Eric Dumazet
2011-02-24 17:48 ` Eric Dumazet
2011-02-25 2:32 ` Po-Yu Chuang
2011-02-25 9:45 ` Po-Yu Chuang
2011-02-25 10:52 ` Eric Dumazet
2011-02-25 18:34 ` David Miller
2011-02-25 18:45 ` Eric Dumazet
2011-02-25 18:47 ` Eric Dumazet
2011-03-01 5:45 ` Po-Yu Chuang
2011-03-01 5:53 ` Eric Dumazet
2011-02-25 9:57 ` [PATCH v6] " Po-Yu Chuang
2011-02-25 11:40 ` Eric Dumazet
2011-03-01 5:20 ` Po-Yu Chuang
2011-03-01 5:26 ` Eric Dumazet
2011-03-01 5:45 ` Eric Dumazet
2011-03-01 5:51 ` Po-Yu Chuang
2011-03-01 5:54 ` Eric Dumazet
2011-03-01 5:59 ` Eric Dumazet
2011-03-01 6:48 ` [PATCH] " Po-Yu Chuang
2011-03-01 7:27 ` Eric Dumazet
2011-03-03 20:19 ` David Miller
2011-02-24 18:43 ` [PATCH v4] " David Miller
2011-01-24 12:39 ` [PATCH v5] " Po-Yu Chuang
2011-01-24 15:07 ` Eric Dumazet
2011-01-25 2:46 ` Po-Yu Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikP1T9XXPVNHnmPnamjwyF5nNn+hVvpovAxTx69@mail.gmail.com \
--to=ratbert.chuang@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ratbert@faraday-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.