All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ketil Froyn <ketil@froyn.name>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Matthieu CASTET <matthieu.castet@parrot.com>,
	dedekind1@gmail.com
Subject: Re: Suggested patch: reset errno after isatty()
Date: Thu, 25 Nov 2010 09:58:01 +0100	[thread overview]
Message-ID: <AANLkTikSEH4SOTYv9oqniP6-pPtRc0Y=M2+8hvdAirRg@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=sKOzXnr-CZLvu_XP4gm5y15pL0HxS+=-=2ij7@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

On Wed, Nov 24, 2010 at 10:36 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
>
> awesome.  can you post your signed-off-by tag and/or a proper git patch please ?
> -mike

I'm pretty new to git. Hope this is right.

Cheers, Ketil

[-- Attachment #2: 0001-mtd-utils-libmtd-legacy-code-OOB.patch --]
[-- Type: text/x-diff, Size: 827 bytes --]

From aea696a42d118598ca582180a89c7e5c0fe13b4e Mon Sep 17 00:00:00 2001
From: Ketil Froyn <ketil@froyn.name>
Date: Thu, 25 Nov 2010 09:52:12 +0100
Subject: [PATCH] mtd-utils: libmtd: legacy code OOB

legacy_get_dev_info() forgot to set the OOB size

Signed-off-by: Ketil Froyn <ketil@froyn.name>
---
 lib/libmtd_legacy.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib/libmtd_legacy.c b/lib/libmtd_legacy.c
index 7488275..d6c3938 100644
--- a/lib/libmtd_legacy.c
+++ b/lib/libmtd_legacy.c
@@ -261,6 +261,7 @@ int legacy_get_dev_info(const char *node, struct mtd_dev_info *mtd)
 	mtd->size = ui.size;
 	mtd->eb_size = ui.erasesize;
 	mtd->min_io_size = ui.writesize;
+	mtd->oob_size = ui.oobsize;
 
 	if (mtd->min_io_size <= 0) {
 		errmsg("mtd%d (%s) has insane min. I/O unit size %d",
-- 
1.7.0.4


  reply	other threads:[~2010-11-25  8:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02 14:37 Suggested patch: reset errno after isatty() Ketil Froyn
2010-11-03  8:23 ` Matthieu CASTET
2010-11-03 13:16   ` Ketil Froyn
2010-11-06  8:54     ` Mike Frysinger
2010-11-07 22:36       ` Ketil Froyn
2010-11-09  9:40         ` Mike Frysinger
2010-11-13 11:07         ` Artem Bityutskiy
2010-11-13 11:55           ` Artem Bityutskiy
2010-11-17 15:50             ` Ketil Froyn
2010-11-18 11:13               ` Ketil Froyn
2010-11-24  7:50                 ` Mike Frysinger
2010-11-24  9:59                   ` Ketil Froyn
2010-11-24 14:12                     ` Artem Bityutskiy
2010-11-24 14:30                       ` Ketil Froyn
2010-11-24 21:36                         ` Mike Frysinger
2010-11-25  8:58                           ` Ketil Froyn [this message]
2010-11-29 15:07                             ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTikSEH4SOTYv9oqniP6-pPtRc0Y=M2+8hvdAirRg@mail.gmail.com' \
    --to=ketil@froyn.name \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=matthieu.castet@parrot.com \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.