From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496Ab0IJRUW (ORCPT ); Fri, 10 Sep 2010 13:20:22 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:54014 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756010Ab0IJRUU convert rfc822-to-8bit (ORCPT ); Fri, 10 Sep 2010 13:20:20 -0400 MIME-Version: 1.0 In-Reply-To: <1284092586-1179-2-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1284092586-1179-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1284092586-1179-2-git-send-email-n-horiguchi@ah.jp.nec.com> From: Linus Torvalds Date: Fri, 10 Sep 2010 10:19:24 -0700 Message-ID: Subject: Re: [PATCH 1/4] hugetlb, rmap: always use anon_vma root pointer To: Naoya Horiguchi Cc: LKML , Andrea Arcangeli , Hugh Dickins , Christoph Lameter , Andrew Morton , Rik van Riel , Peter Zijlstra , Andi Kleen , linux-mm Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 9, 2010 at 9:23 PM, Naoya Horiguchi wrote: > This patch applies Andrea's fix given by the following patch into hugepage > rmapping code: > >  commit 288468c334e98aacbb7e2fb8bde6bc1adcd55e05 >  Author: Andrea Arcangeli >  Date:   Mon Aug 9 17:19:09 2010 -0700 > > This patch uses anon_vma->root and avoids unnecessary overwriting when > anon_vma is already set up. Btw, why isn't the code in __page_set_anon_rmap() also doing this cleaner version (ie a single "if (PageAnon(page)) return;" up front)? The comments in that function are also some alien language translated to english by some broken automatic translation service. Could somebody clean up that function and come up with a comment that actually parses as English and makes sense? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 041B36B00B9 for ; Fri, 10 Sep 2010 13:25:39 -0400 (EDT) Received: from mail-iw0-f169.google.com (mail-iw0-f169.google.com [209.85.214.169]) (authenticated bits=0) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id o8AHP8MK017466 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=FAIL) for ; Fri, 10 Sep 2010 10:25:08 -0700 Received: by iwn33 with SMTP id 33so3162670iwn.14 for ; Fri, 10 Sep 2010 10:25:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1284092586-1179-2-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1284092586-1179-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1284092586-1179-2-git-send-email-n-horiguchi@ah.jp.nec.com> From: Linus Torvalds Date: Fri, 10 Sep 2010 10:19:24 -0700 Message-ID: Subject: Re: [PATCH 1/4] hugetlb, rmap: always use anon_vma root pointer Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: Naoya Horiguchi Cc: LKML , Andrea Arcangeli , Hugh Dickins , Christoph Lameter , Andrew Morton , Rik van Riel , Peter Zijlstra , Andi Kleen , linux-mm List-ID: On Thu, Sep 9, 2010 at 9:23 PM, Naoya Horiguchi wrote: > This patch applies Andrea's fix given by the following patch into hugepag= e > rmapping code: > > =A0commit 288468c334e98aacbb7e2fb8bde6bc1adcd55e05 > =A0Author: Andrea Arcangeli > =A0Date: =A0 Mon Aug 9 17:19:09 2010 -0700 > > This patch uses anon_vma->root and avoids unnecessary overwriting when > anon_vma is already set up. Btw, why isn't the code in __page_set_anon_rmap() also doing this cleaner version (ie a single "if (PageAnon(page)) return;" up front)? The comments in that function are also some alien language translated to english by some broken automatic translation service. Could somebody clean up that function and come up with a comment that actually parses as English and makes sense? Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org