From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39038 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PVgSg-00064K-F7
	for qemu-devel@nongnu.org; Thu, 23 Dec 2010 03:23:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PVgSf-0004cl-0N
	for qemu-devel@nongnu.org; Thu, 23 Dec 2010 03:23:46 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:33597)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PVgSe-0004cf-Q3
	for qemu-devel@nongnu.org; Thu, 23 Dec 2010 03:23:44 -0500
Received: by wyg36 with SMTP id 36so6354092wyg.4
	for <qemu-devel@nongnu.org>; Thu, 23 Dec 2010 00:23:44 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1292879604-22268-2-git-send-email-agraf@suse.de>
References: <1292879604-22268-1-git-send-email-agraf@suse.de>
	<1292879604-22268-2-git-send-email-agraf@suse.de>
Date: Thu, 23 Dec 2010 08:23:43 +0000
Message-ID: <AANLkTikVe+NV5Lsr78JA8+V1b5bK-hghwH640BWpBeqH@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/8] ahci: split ICH9 from core
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Joerg Roedel <Joerg.Roedel@amd.com>, Sebastian Herbszt <herbszt@gmx.de>, qemu-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On Mon, Dec 20, 2010 at 9:13 PM, Alexander Graf <agraf@suse.de> wrote:
> From: Sebastian Herbszt <herbszt@gmx.de>
>
> There are multiple ahci devices out there. The currently implemented ich-=
9
> is only one of the many. So let's split that one out into a separate file
> to stress the difference.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> =A0Makefile.objs | =A0 =A01 +
> =A0hw/ide/ahci.c | =A0305 +----------------------------------------------=
---------
> =A0hw/ide/ahci.h | =A0309 +++++++++++++++++++++++++++++++++++++++++++++++=
++++++++++
> =A0hw/ide/ich.c =A0| =A0 61 +++++++++++
> =A04 files changed, 375 insertions(+), 301 deletions(-)
> =A0create mode 100644 hw/ide/ahci.h
> =A0create mode 100644 hw/ide/ich.c

Do you want to add copyright headers on the new files?

Right now it seems there's not much ICH-9 specific stuff but the
motivation behind this patch is good.

Stefan