All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michel Lespinasse <walken@google.com>
To: Tony Luck <tony.luck@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	David Howells <dhowells@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mike Waychison <mikew@google.com>,
	Suleiman Souhlal <suleiman@google.com>,
	Ying Han <yinghan@google.com>
Subject: Re: [PATCH 06/11] rwsem: wake queued readers when writer blocks on active read lock
Date: Fri, 13 Aug 2010 16:48:46 -0700	[thread overview]
Message-ID: <AANLkTikXwPRoL0VzcqX0gATw=k0AkJaG1Xk9Df0vht7D@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=o6g2cxcL_F-ZTZZkMUFT39jLtyRdTigZRbA5o@mail.gmail.com>

On Fri, Aug 13, 2010 at 4:38 PM, Tony Luck <tony.luck@gmail.com> wrote:
> Aha!. I think I found it.
>
> This embarrassing declaration in ia64's asm/atomic.h:
>
> static __inline__ int
> ia64_atomic64_add (__s64 i, atomic64_t *v)
>
> looks to be the key.  Obviously it would be better to return all
> 64 bits of the answer using "long" rather than just 32 bits with "int".

Aha, good catch. Thanks for going to the bottom of this, it would have
taken me forever to figure it out (and I could not test this).

BTW there seems to be the same issue in ia64_atomic64_sub() too
(though I wonder if that ever gets used :)

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

  reply	other threads:[~2010-08-13 23:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24 20:31 [PATCH 00/11] V4: rwsem changes + down_read_critical() proposal Michel Lespinasse
2010-05-24 20:31 ` [PATCH 01/11] x86 rwsem: stay on fast path when count>0 in __up_write() Michel Lespinasse
2010-05-24 20:31 ` [PATCH 02/11] x86 rwsem: minor cleanups Michel Lespinasse
2010-05-24 20:31 ` [PATCH 03/11] rwsem: fully separate code pathes to wake writers vs readers Michel Lespinasse
2010-05-24 20:31 ` [PATCH 04/11] rwsem: lighter active count checks when waking up readers Michel Lespinasse
2010-05-24 20:49   ` Daniel Walker
2010-05-24 20:31 ` [PATCH 05/11] rwsem: let RWSEM_WAITING_BIAS represent any number of waiting threads Michel Lespinasse
2010-05-24 20:31 ` [PATCH 06/11] rwsem: wake queued readers when writer blocks on active read lock Michel Lespinasse
2010-08-12  1:24   ` Tony Luck
2010-08-12  5:02     ` Michel Lespinasse
2010-08-12  5:09       ` Michel Lespinasse
2010-08-12 15:57         ` Linus Torvalds
2010-08-12 16:24           ` Tony Luck
2010-08-12 22:23             ` Tony Luck
2010-08-13 16:09               ` Tony Luck
2010-08-13 21:19                 ` Tony Luck
2010-08-13 23:38                   ` Tony Luck
2010-08-13 23:48                     ` Michel Lespinasse [this message]
2010-08-12 16:22       ` Tony Luck
2010-05-24 20:31 ` [PATCH 07/11] rwsem: smaller wrappers around rwsem_down_failed_common Michel Lespinasse
2010-05-24 20:31 ` [PATCH 08/11] generic rwsem: implement down_read_critical() / up_read_critical() Michel Lespinasse
2010-05-24 20:31 ` [PATCH 09/11] rwsem: down_read_critical infrastructure support Michel Lespinasse
2010-05-24 20:31 ` [PATCH 10/11] x86 rwsem: down_read_critical implementation Michel Lespinasse
2010-05-24 20:31 ` [PATCH 11/11] Use down_read_critical() for /proc/<pid>/exe and /proc/<pid>/maps files Michel Lespinasse
2010-05-24 21:12   ` Daniel Walker
2010-05-27 14:12   ` Arjan van de Ven
2010-05-25  8:47 ` [PATCH 00/11] V4: rwsem changes + down_read_critical() proposal Peter Zijlstra
2010-05-25  9:12   ` Michel Lespinasse
2010-05-25  9:27     ` Peter Zijlstra
2010-05-26  1:23       ` KAMEZAWA Hiroyuki
2010-05-27 11:02         ` Michel Lespinasse
2010-05-27 11:45           ` Peter Zijlstra
2010-05-27 10:59       ` Michel Lespinasse
2010-05-27 11:18         ` Peter Zijlstra
2010-05-27 11:47           ` Michel Lespinasse
2010-05-25 15:16   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTikXwPRoL0VzcqX0gATw=k0AkJaG1Xk9Df0vht7D@mail.gmail.com' \
    --to=walken@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikew@google.com \
    --cc=mingo@elte.hu \
    --cc=suleiman@google.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.