From mboxrd@z Thu Jan 1 00:00:00 1970 From: Blue Swirl Subject: Re: [PATCHv6 00/16] boot order specification Date: Sun, 28 Nov 2010 12:39:13 +0000 Message-ID: References: <1290012243-6087-1-git-send-email-gleb@redhat.com> <20101123153141.GD25606@redhat.com> <4CEBE7F4.9080200@linux.vnet.ibm.com> <4CF1706A.3000507@redhat.com> <20101128075404.GF6897@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Avi Kivity , Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, armbru@redhat.com, alex.williamson@redhat.com, mst@redhat.com, kevin@koconnor.net, Anthony Liguori To: Gleb Natapov Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:47972 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752563Ab0K1Mjf (ORCPT ); Sun, 28 Nov 2010 07:39:35 -0500 Received: by pwj3 with SMTP id 3so607658pwj.19 for ; Sun, 28 Nov 2010 04:39:35 -0800 (PST) In-Reply-To: <20101128075404.GF6897@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Nov 28, 2010 at 7:54 AM, Gleb Natapov wrote: > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: >> On 11/23/2010 06:12 PM, Anthony Liguori wrote: >> >On 11/23/2010 09:31 AM, Gleb Natapov wrote: >> >>Anthony, Blue >> >> >> >>No comments on this patch series for almost a week. Can it be applied? >> > >> >Does that mean everyone's happy or have folks not gotten around to >> >review it? >> > >> >IOW, last call if you have objections :-) >> > >> >> I haven't reviewed this - I trust the author and maintainers to get >> it right. >> >> But I notice the there is no documentation - surely some is needed? >> > > The patch creates Openfirmware device path from qdev > hierarchy. Each element of a device path depends on type of a bus > the device resides on. You can find various bus bindings here: > http://playground.sun.com/1275/bindings/ and main spec is here > http://forthworks.com/standards/of1275.pdf. Format in which list of > device paths is passed to firmware is documented by comment (it is very > simple). The only thing missing is command line option documentation. I > will add it and resend if no more changes are needed for patch to be > excepted. The patches don't apply anymore due to recent changes to pcnet.c. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39109 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMgXf-00036k-LF for qemu-devel@nongnu.org; Sun, 28 Nov 2010 07:39:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PMgXY-0006nh-Br for qemu-devel@nongnu.org; Sun, 28 Nov 2010 07:39:43 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:46364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PMgXY-0006nS-6E for qemu-devel@nongnu.org; Sun, 28 Nov 2010 07:39:36 -0500 Received: by pzk2 with SMTP id 2so687308pzk.4 for ; Sun, 28 Nov 2010 04:39:35 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20101128075404.GF6897@redhat.com> References: <1290012243-6087-1-git-send-email-gleb@redhat.com> <20101123153141.GD25606@redhat.com> <4CEBE7F4.9080200@linux.vnet.ibm.com> <4CF1706A.3000507@redhat.com> <20101128075404.GF6897@redhat.com> From: Blue Swirl Date: Sun, 28 Nov 2010 12:39:13 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] Re: [PATCHv6 00/16] boot order specification List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Anthony Liguori , kvm@vger.kernel.org, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , alex.williamson@redhat.com, kevin@koconnor.net, Avi Kivity On Sun, Nov 28, 2010 at 7:54 AM, Gleb Natapov wrote: > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: >> On 11/23/2010 06:12 PM, Anthony Liguori wrote: >> >On 11/23/2010 09:31 AM, Gleb Natapov wrote: >> >>Anthony, Blue >> >> >> >>No comments on this patch series for almost a week. Can it be applied? >> > >> >Does that mean everyone's happy or have folks not gotten around to >> >review it? >> > >> >IOW, last call if you have objections :-) >> > >> >> I haven't reviewed this - I trust the author and maintainers to get >> it right. >> >> But I notice the there is no documentation - surely some is needed? >> > > The patch creates Openfirmware device path from qdev > hierarchy. Each element of a device path depends on type of a bus > the device resides on. You can find various bus bindings here: > http://playground.sun.com/1275/bindings/ and main spec is here > http://forthworks.com/standards/of1275.pdf. Format in which list of > device paths is passed to firmware is documented by comment (it is very > simple). The only thing missing is command line option documentation. I > will add it and resend if no more changes are needed for patch to be > excepted. The patches don't apply anymore due to recent changes to pcnet.c.