All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH 1/3] Add virtioblk_id tool to extract drive serial numbers
Date: Mon, 14 Jun 2010 08:54:44 +0000	[thread overview]
Message-ID: <AANLkTikddNticflC8dTfZCH6deK4KG2PtLYauEVWi4PM@mail.gmail.com> (raw)
In-Reply-To: <1275592024-2625-2-git-send-email-ryanh@us.ibm.com>

On Thu, Jun 10, 2010 at 21:16, Ryan Harper <ryanh@us.ibm.com> wrote:
> Use the 'VBID' virtio-blk ioctl to extract drive serial numbers
> to be used for building disk/by-id symlinks.  After extracting
> the serial number of the device it prints out the minimum info
> needed in a similar format to `scsi_id --export` so that the
> persistent-storage rules can process the serial information.
>
> This program depends on the virtio-blk serial device patches posted
> here[1] being applied to qemu and linux-kernel.
>
> Here is what the output looks like:
>
> % ./virtioblk_id /dev/vdb
> ID_VIRTIO=1
> ID_TYPE=disk
> ID_SERIAL=QM00001
> ID_SERIAL_SHORT=QM00001

As requested in the ealier mail. Please provide a good reason why the
kernel code can not create a "serial" file (or whatever fits your
needs) in sysfs at the block device.

Other subsystems are doing the same thing like:
  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/mmc/core/mmc.c;h‰f7a25b7ac12ab17f7baa9a18e0d980fe1c50eb;hb=HEAD#l270

We don't like to accumulate special purpose tools based on rather
weird ioctls for newly developed stuff, which can be replaced with a
few obviously and generally useful lines of code in the kernel driver.

As I think the general direction of solving the problem you describe
is fundamentally wrong, I'll apply this only, if there are valid
reasons not to add this to sysfs.

Thanks,
Kay

  parent reply	other threads:[~2010-06-14  8:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03 19:07 [Qemu-devel] [PATCH 0/3] Add virtio-blk support to persistent-storage rules Ryan Harper
2010-06-03 19:07 ` Ryan Harper
2010-06-03 19:07 ` [PATCH 1/3] Add virtioblk_id tool to extract drive serial numbers Ryan Harper
2010-06-03 19:52   ` Kay Sievers
2010-06-03 20:01   ` Ryan Harper
2010-06-03 20:04   ` Kay Sievers
2010-06-03 20:13   ` David Zeuthen
2010-06-03 21:03   ` Ryan Harper
2010-06-04 15:06     ` [Qemu-devel] " john cooper
2010-06-04 15:06       ` john cooper
2010-06-10 19:16   ` Ryan Harper
2010-06-14  8:54   ` Kay Sievers [this message]
2010-06-14 13:15   ` Ryan Harper
2010-06-14 13:29   ` Kay Sievers
2010-06-29 14:48   ` Ryan Harper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikddNticflC8dTfZCH6deK4KG2PtLYauEVWi4PM@mail.gmail.com \
    --to=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.