From: Linus Torvalds <torvalds@linux-foundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
John Kacur <jkacur@redhat.com>, Sam Ravnborg <sam@ravnborg.org>,
Jan Blunck <jblunck@suse.de>,
linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [RFC] annotating the remaining BKL users
Date: Wed, 8 Sep 2010 17:20:57 -0700 [thread overview]
Message-ID: <AANLkTikfLb+kDZN8aodPwxFuL_VOuyb7AH=eF60MwrWG@mail.gmail.com> (raw)
In-Reply-To: <201009082255.33035.arnd@arndb.de>
On Wed, Sep 8, 2010 at 1:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> I'd like to hear preferences for one approach or the other,
> especially from Linus, so we can give this some better testing
> in -next before the merge window.
Hmm. I like your patch. It seems to have a good balance of "select
BKL" (for architectures that require it for some reason) and "depends
on BKL" (for individual modules).
That said, I'd also like to see a comment _why_ the architectures in
question depends on the BKL. Some of those look pretty historical (the
sparc32 register window spill code? Does it _really_ need the BKL at
all, or is that just a remnant of "let's get the BKL at each kernel
entry").
So with the added rule that "each select BKL needs a quick comment
why", I'd be happy with it. And maybe it would make people take a
second look.
Linus
next prev parent reply other threads:[~2010-09-09 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 20:55 [RFC] annotating the remaining BKL users Arnd Bergmann
2010-09-09 0:20 ` Linus Torvalds [this message]
2010-09-09 3:53 ` David Miller
2010-09-09 11:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikfLb+kDZN8aodPwxFuL_VOuyb7AH=eF60MwrWG@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=jblunck@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.