From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:61681 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753908Ab0KRWCL convert rfc822-to-8bit (ORCPT ); Thu, 18 Nov 2010 17:02:11 -0500 MIME-Version: 1.0 In-Reply-To: References: <1290109970-26752-1-git-send-email-gbean@codeaurora.org> <1290109970-26752-2-git-send-email-gbean@codeaurora.org> Date: Thu, 18 Nov 2010 14:02:09 -0800 Message-ID: Subject: Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib. From: Janakiram Sistla Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Gregory Bean Cc: dwalker@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On Thu, Nov 18, 2010 at 12:59 PM, Gregory Bean wrote: >>>> Do you mean to MSM have v1 and v2 gpio hardware ??? can not we >>>> have one file under mach-msm as gpio.c?? >>> >>> The MSM8x60 is the first MSM chip to carry the second-generation, or v2, >>> GPIO hardware block.  This block is not backward compatible with the >>> v1 block found on older MSMs, so the two drivers cannot be elegantly >>> merged. >> >> so this is applicable to 8x60 and coming chip sets.I basically have a >> question,How come a a new person under stand the  chipset uses gpio-v1 >> or gpiov2?? > > Targets with the v2 block define CONFIG_MSM_V2_TLMM. So in that case we can name it as gpio-tlmm.c ?? > -- > Employee of Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: janakiram.sistla@gmail.com (Janakiram Sistla) Date: Thu, 18 Nov 2010 14:02:09 -0800 Subject: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib. In-Reply-To: References: <1290109970-26752-1-git-send-email-gbean@codeaurora.org> <1290109970-26752-2-git-send-email-gbean@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Nov 18, 2010 at 12:59 PM, Gregory Bean wrote: >>>> Do you mean to MSM have v1 and v2 gpio hardware ??? can not we >>>> have one file under mach-msm as gpio.c?? >>> >>> The MSM8x60 is the first MSM chip to carry the second-generation, or v2, >>> GPIO hardware block. ?This block is not backward compatible with the >>> v1 block found on older MSMs, so the two drivers cannot be elegantly >>> merged. >> >> so this is applicable to 8x60 and coming chip sets.I basically have a >> question,How come a a new person under stand the ?chipset uses gpio-v1 >> or gpiov2?? > > Targets with the v2 block define CONFIG_MSM_V2_TLMM. So in that case we can name it as gpio-tlmm.c ?? > -- > Employee of Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.