All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Christophe Lyon <christophe.lyon@st.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] softfloat: export float32_nan and float32_infinity.
Date: Wed, 16 Feb 2011 11:53:49 +0000	[thread overview]
Message-ID: <AANLkTikpuYXqzDEqQJSRgmCAKFdUsseR=nFix0RWB0tB@mail.gmail.com> (raw)
In-Reply-To: <4D595CB8.4020901@st.com>

On 14 February 2011 16:47, Christophe Lyon <christophe.lyon@st.com> wrote:
>
> These two special values are needed to implement some helper functions, which return these values in some cases.

I assume this is for vrecpe, right? I think it would be better
to post this as part of that patchset; it's easier to see the
rationale for adding the functions when you also have the
code that's using them.

>  /*----------------------------------------------------------------------------
> +| Returns the default NaN.
> +*----------------------------------------------------------------------------*/
> +
> +float32 float32_nan(void)
> +{
> +    return float32_default_nan;
> +}

Maybe we should just expose float32_default_nan in
softfloat.h somehow; that would match float32_zero,
float32_one, etc (ie it would not be a function).

> +#define float32_infinity make_float32(0x7f800000)

No objection to this one.

-- PMM

  reply	other threads:[~2011-02-16 11:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 16:47 [Qemu-devel] [PATCH] softfloat: export float32_nan and float32_infinity Christophe Lyon
2011-02-16 11:53 ` Peter Maydell [this message]
2011-02-16 13:02   ` Christophe Lyon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTikpuYXqzDEqQJSRgmCAKFdUsseR=nFix0RWB0tB@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=christophe.lyon@st.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.