From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Chua Subject: Re: [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management Date: Sun, 23 Jan 2011 08:14:57 +0800 Message-ID: References: <201101201226.41021.rjw@sisk.pl> <201101221025.49327.rjw@sisk.pl> <201101222012.14028.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:41816 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947Ab1AWAO6 convert rfc822-to-8bit (ORCPT ); Sat, 22 Jan 2011 19:14:58 -0500 In-Reply-To: <201101222012.14028.rjw@sisk.pl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Len Brown , LKML , ACPI Devel Maling List , Linux-pm mailing list , Matthew Garrett On Sun, Jan 23, 2011 at 3:12 AM, Rafael J. Wysocki wrote: > On Saturday, January 22, 2011, Jeff Chua wrote: >> 2011/1/22 Rafael J. Wysocki : >> > On Saturday, January 22, 2011, Jeff Chua wrote: >> >> > means that my patch [11/11] _and_ the replacement are totally wron= g, because you have >> > _multiple_ NVS regions. =A0That really helped, thanks a lot. >> >> Would it be different if I offline all CPUs before suspending to ram= ? >> It seems to help with suspending to disk. > > No, that doesn't matter. =A0NVS regions are just sitting there regard= less of > what happens at run time. Strange. If I didn't offline, it hanged during suspend even without thinkpad_acpi. I could see that the suspend code does the offline automatically, but executing the offline before calling suspend makes it no hanging. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446Ab1AWAO7 (ORCPT ); Sat, 22 Jan 2011 19:14:59 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:41816 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947Ab1AWAO6 convert rfc822-to-8bit (ORCPT ); Sat, 22 Jan 2011 19:14:58 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=PlPZGiNY+ba+wnc5Ypgk7YFFAYqZI8e+QAznubVvYvwHwkazo978/1WNpu9ecuP3xD wQrXYF4uK3OhwIG9B9rq8jbilSfm9YJVWZOxiH4GbknCmaEy5glug6z9hkY3LY5jCImr 4DharMlf1ycQjMn0ey01prT5+Uu6DJbmLtva8= MIME-Version: 1.0 In-Reply-To: <201101222012.14028.rjw@sisk.pl> References: <201101201226.41021.rjw@sisk.pl> <201101221025.49327.rjw@sisk.pl> <201101222012.14028.rjw@sisk.pl> Date: Sun, 23 Jan 2011 08:14:57 +0800 Message-ID: Subject: Re: [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management From: Jeff Chua To: "Rafael J. Wysocki" Cc: Len Brown , LKML , ACPI Devel Maling List , Linux-pm mailing list , Matthew Garrett Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 23, 2011 at 3:12 AM, Rafael J. Wysocki wrote: > On Saturday, January 22, 2011, Jeff Chua wrote: >> 2011/1/22 Rafael J. Wysocki : >> > On Saturday, January 22, 2011, Jeff Chua wrote: >> >> > means that my patch [11/11] _and_ the replacement are totally wrong, because you have >> > _multiple_ NVS regions.  That really helped, thanks a lot. >> >> Would it be different if I offline all CPUs before suspending to ram? >> It seems to help with suspending to disk. > > No, that doesn't matter.  NVS regions are just sitting there regardless of > what happens at run time. Strange. If I didn't offline, it hanged during suspend even without thinkpad_acpi. I could see that the suspend code does the offline automatically, but executing the offline before calling suspend makes it no hanging. Jeff