Re: [PATCH] gphoto2_2.4.8.bb: Stop configure from looking in /usr/local/include

[Khem Raj <raj.khem@gmail.com>]

On Mon, Nov 1, 2010 at 11:38 PM, Frans Meulenbroeks
<fransmeulenbroeks@gmail.com> wrote:
> 2010/11/2 Graham Gower <graham.gower@gmail.com>:
>>  * Point configure at where it can find jpeg.
>>  * Explicitly disable cdk and aalib.
>>  * Fix license while here.
>>
>> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>> ---
>>  recipes/gphoto2/gphoto2_2.4.8.bb |    9 +++++++--
>>  1 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes/gphoto2/gphoto2_2.4.8.bb b/recipes/gphoto2/gphoto2_2.4.8.bb
>> index ea54713..836ea85 100644
>> --- a/recipes/gphoto2/gphoto2_2.4.8.bb
>> +++ b/recipes/gphoto2/gphoto2_2.4.8.bb
>> @@ -1,7 +1,8 @@
>>  DESCRIPTION = "gphoto2 is a command-line utility to fetch pictures from digital cameras"
>>  SECTION = "console/utils"
>> -LICENSE = "GPL"
>> -DEPENDS = "libtool libgphoto2 popt"
>> +LICENSE = "GPLv2+"
>> +DEPENDS = "libtool libgphoto2 popt jpeg"
>
> The original recipe would build without the depends on jpeg
> adding it to depends should be mentioned in the commit message
>
>> +PR = "r1"
>>
>>  SRC_URI = "${SOURCEFORGE_MIRROR}/gphoto/gphoto2-${PV}.tar.bz2;name=gphoto2 \
>>            file://gphoto-popt-fixup.patch"
>> @@ -11,6 +12,10 @@ SRC_URI[gphoto2.sha256sum] = "a2e2f70fd6051234cbc3d76dc82df6991e8a07ead56aa8d5c4
>>
>>  inherit autotools
>>
>> +EXTRA_OECONF="--without-cdk \
>> +               --without-aalib \
>> +               --with-jpeg-prefix=${STAGING_EXECPREFIXDIR}"
>> +
>
> I have some concerns here.
> For configure it seems best to explicitly set and reset the flags in
> it, otherwise you may just pick up whatever happened to be build
> before.
>


this is the case with any package that uses configure tools. But assumption here
is that when you are building you are not building stuff thats not
meant to be in
the given image.

Thx
-Khem