From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 3/7] ARM: tegra: clock: Check for clk_num == 0 Date: Mon, 21 Feb 2011 21:29:08 -0800 Message-ID: References: <1298342392-21236-1-git-send-email-ccross@android.com> <1298342392-21236-4-git-send-email-ccross@android.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1298342392-21236-4-git-send-email-ccross@android.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin Cross Cc: linux-tegra@vger.kernel.org, konkers@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mike@compulab.co.il, Russell King List-Id: linux-tegra@vger.kernel.org On Mon, Feb 21, 2011 at 6:39 PM, Colin Cross wrote= : > Peripheral clocks that have no clock enable bit in the > enable registers have their clk_num set to 0. =A0Bit 0 > in the clock enable registers is the CPU clock. > Prevent disables on these peripheral clocks from > accidentally disabling the CPU clock. > > Signed-off-by: Colin Cross Acked-by: Olof Johansson May I suggest a slightly more descriptive patch subject though? "ARM: tegra: clock: prevent accidental disables of cpu clock" or similar, maybe. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Date: Mon, 21 Feb 2011 21:29:08 -0800 Subject: [PATCH 3/7] ARM: tegra: clock: Check for clk_num == 0 In-Reply-To: <1298342392-21236-4-git-send-email-ccross@android.com> References: <1298342392-21236-1-git-send-email-ccross@android.com> <1298342392-21236-4-git-send-email-ccross@android.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Feb 21, 2011 at 6:39 PM, Colin Cross wrote: > Peripheral clocks that have no clock enable bit in the > enable registers have their clk_num set to 0. ?Bit 0 > in the clock enable registers is the CPU clock. > Prevent disables on these peripheral clocks from > accidentally disabling the CPU clock. > > Signed-off-by: Colin Cross Acked-by: Olof Johansson May I suggest a slightly more descriptive patch subject though? "ARM: tegra: clock: prevent accidental disables of cpu clock" or similar, maybe. -Olof