From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [patch] fs: fix superblock iteration race Date: Fri, 11 Jun 2010 21:46:49 -0700 Message-ID: References: <20100611145009.GE16436@laptop> <20100612035751.GG16436@laptop> <20100612043848.GH16436@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Al Viro , linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:47416 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752251Ab0FLEr3 (ORCPT ); Sat, 12 Jun 2010 00:47:29 -0400 Received: from mail-yw0-f204.google.com (mail-yw0-f204.google.com [209.85.211.204]) (authenticated bits=0) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id o5C4ktrL012955 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=FAIL) for ; Fri, 11 Jun 2010 21:47:00 -0700 Received: by ywh42 with SMTP id 42so1989107ywh.15 for ; Fri, 11 Jun 2010 21:46:49 -0700 (PDT) In-Reply-To: <20100612043848.GH16436@laptop> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jun 11, 2010 at 9:38 PM, Nick Piggin wrote: > > In fairness I added a lot more comments and a bit of whitespace, > accounting for about half of those lines added. Yeah, ok. As mentioned, I can certainly go either way. > I wouldn't mind a list macro to reset. I'd prefer the name > match better with the iterator macro though. > list_safe_reset_next()? Yeah, it needs to be at least "list_" something. So "list_safe_reset_next()" sounds as good as anything else. I wouldn't expect it to be very common. Linus