From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37106 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMSfv-0007Dt-DF for qemu-devel@nongnu.org; Wed, 09 Jun 2010 17:19:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMSfu-0004nL-A6 for qemu-devel@nongnu.org; Wed, 09 Jun 2010 17:19:03 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:44862) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMSfu-0004nE-7d for qemu-devel@nongnu.org; Wed, 09 Jun 2010 17:19:02 -0400 Received: by yxk8 with SMTP id 8so1339208yxk.4 for ; Wed, 09 Jun 2010 14:19:01 -0700 (PDT) MIME-Version: 1.0 Sender: tamura.yoshiaki@gmail.com In-Reply-To: <20100609175215.2e2071a0@redhat.com> References: <20100609175215.2e2071a0@redhat.com> Date: Thu, 10 Jun 2010 06:19:00 +0900 Message-ID: Subject: Re: [Qemu-devel] [PATCH v3 0/5] Add QMP migration events From: Yoshiaki Tamura Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Juan Quintela 2010/6/10 Luiz Capitulino : > On Wed, =A09 Jun 2010 14:10:53 +0200 > Juan Quintela wrote: > >> This is a resent with what we agreed on yesterday call. >> Migration events would be there for 0.13 until we get proper >> async command support. > > =A0Something which is not clear to me is the set of events we'd have if m= igrate > was an async command. > > =A0Ie, do we really need MIGRATION_FAILED in this case? Don't we expect t= o get > this information from the async response? There would be two types of MIGRATION_FAILED. One for errors happen during setup of live migration, and one for during the process of live migration. The former is a synchronous event, and later would be an asynchronous event (if you didn't use -d option, this should also be a synchronous event). I'm not sure whether we should distinguish these failures or not. Yoshi > >> >> Later, Juan. >> >> v3: >> - Add comment that MIGRATION_FAILURE will add a QError for 0.14 >> =A0 (when we get internal support for that) >> =A0 rebase against today tree >> >> v2: >> - Address pbonzini and mst changes >> =A0 (error messages and doc fixes) >> >> v1: >> >> This series does: >> >> - exit incoming migration on failure. =A0For exec/fd migrations, once >> =A0 there was a failure, there was nothing useful to do. =A0And for tcp >> =A0 migration, not exiting created interesting bugs when trying to >> =A0 migrate again to a process with a faild migration. >> >> - Factorize common migration code, no more duplication, makes easier to = do >> =A0 "global" migration things, like QMP events. >> >> - Introduce QMP events, both for incoming and outgoing migration. >> >> >> Now, the million dollar question: Why I didn't refactorize outgoing >> migration? =A0I tried, and have it partially done on my local tree. =A0B= ut >> it depends (too much) of current_migration global variable -> Libvirt >> folks will also want "info migrate" to work on the incoming side, >> i.e. current_migraition has to also be updated on incoming side. =A0Done >> until here, but then I hit the wall "incoming migration is synchronous". >> >> To make the monitor work on incoming migration, we need to change >> buffered_file.c abstraction to also work for incoming fd's, or another >> similar solution. =A0I am open to suggestions about what to do here. >> >> This series are quite simple (the unfinished part is more complex), >> will send the other part as an RFC later. >> >> Please review and consider to apply it. >> >> Later, Juan. >> >> Juan Quintela (5): >> =A0 Exit if incoming migration fails >> =A0 Factorize common migration incoming code >> =A0 QMP: Introduce MIGRATION events >> =A0 QMP: Emit migration events on incoming migration >> =A0 QMP: Emit migration events on outgoing migration >> >> =A0QMP/qmp-events.txt | =A0 52 +++++++++++++++++++++++++++++++++++++++++= +++++++++++ >> =A0migration-exec.c =A0 | =A0 17 +++-------------- >> =A0migration-fd.c =A0 =A0 | =A0 15 ++------------- >> =A0migration-tcp.c =A0 =A0| =A0 17 ++++------------- >> =A0migration-unix.c =A0 | =A0 17 ++++------------- >> =A0migration.c =A0 =A0 =A0 =A0| =A0 37 +++++++++++++++++++++++++++++++--= ---- >> =A0migration.h =A0 =A0 =A0 =A0| =A0 =A04 +++- >> =A0monitor.c =A0 =A0 =A0 =A0 =A0| =A0 12 ++++++++++++ >> =A0monitor.h =A0 =A0 =A0 =A0 =A0| =A0 =A04 ++++ >> =A0vl.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A07 ++++++- >> =A010 files changed, 121 insertions(+), 61 deletions(-) >> >> > > >