All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Seungwhan Youn <sw.youn@samsung.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	jassi.brar@samsung.com, lrg@slimlogic.co.uk
Subject: Re: [PATCH 4/4] ASoC: SAMSUNG: Clean-up header includes
Date: Fri, 7 Jan 2011 15:08:49 +0900	[thread overview]
Message-ID: <AANLkTim+ANz=cszy4gbiWAToPFAMokKe3z9JCZVzHddm@mail.gmail.com> (raw)
In-Reply-To: <1294376262-18364-1-git-send-email-sw.youn@samsung.com>

On Fri, Jan 7, 2011 at 1:57 PM, Seungwhan Youn <sw.youn@samsung.com> wrote:
> This patch remove including unnecessary/duplicated headers which relative
> with Samsung SoCs.
>
> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
> ---
>  sound/soc/samsung/ac97.c                       |    8 +++-----
>  sound/soc/samsung/dma.c                        |   12 +++---------
>  sound/soc/samsung/goni_wm8994.c                |   10 +---------
>  sound/soc/samsung/h1940_uda1380.c              |   11 +----------
>  sound/soc/samsung/i2s.c                        |    7 +++----
>  sound/soc/samsung/jive_wm8750.c                |   11 -----------
>  sound/soc/samsung/ln2440sbc_alc650.c           |    6 ------
>  sound/soc/samsung/neo1973_gta02_wm8753.c       |   15 ++-------------
>  sound/soc/samsung/pcm.c                        |   15 +++------------
>  sound/soc/samsung/rx1950_uda1380.c             |   14 +-------------
>  sound/soc/samsung/s3c-i2s-v2.c                 |    7 +++----
>  sound/soc/samsung/s3c2412-i2s.c                |   16 +++-------------
>  sound/soc/samsung/s3c24xx-i2s.c                |   18 +++---------------
>  sound/soc/samsung/s3c24xx_simtec.c             |   12 ++----------
>  sound/soc/samsung/s3c24xx_simtec_hermes.c      |   10 ----------
>  sound/soc/samsung/s3c24xx_simtec_tlv320aic23.c |   12 ------------
>  sound/soc/samsung/s3c24xx_uda134x.c            |   12 ++----------
>  sound/soc/samsung/smartq_wm8987.c              |    9 +--------
>  sound/soc/samsung/smdk2443_wm9710.c            |    6 ------
>  sound/soc/samsung/smdk_spdif.c                 |    9 ++-------
>  sound/soc/samsung/smdk_wm8580.c                |    7 +------
>  sound/soc/samsung/smdk_wm9713.c                |    4 ----
>  sound/soc/samsung/spdif.c                      |    7 +++----
>  23 files changed, 37 insertions(+), 201 deletions(-)
>
> diff --git a/sound/soc/samsung/ac97.c b/sound/soc/samsung/ac97.c
> index 1e84ee0..18528d8 100644
> --- a/sound/soc/samsung/ac97.c
> +++ b/sound/soc/samsung/ac97.c
> @@ -12,16 +12,14 @@
>  * published by the Free Software Foundation.
>  */
>
> -#include <linux/init.h>
> -#include <linux/module.h>
> +#include <sound/soc.h>
> +
>  #include <linux/io.h>
>  #include <linux/delay.h>
>  #include <linux/clk.h>
>
> -#include <sound/soc.h>
> -
> -#include <plat/regs-ac97.h>
>  #include <mach/dma.h>
> +#include <plat/regs-ac97.h>
>  #include <plat/audio.h>

I think we'd better keep sound includes after linux's.
Same for all such instances in the remaining of the patch.
Otherwise, the patch is ok.

Thanks
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2011-01-07  6:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-07  4:43 [PATCH 0/4] ASoC: SAMSUNG: Code clean-up suitable for current ASoC Seungwhan Youn
2011-01-07  4:46 ` [PATCH 1/4] ASoC: SAMSUNG: Remove AC97 header file Seungwhan Youn
2011-01-07  4:51   ` [PATCH 2/4] ASoC: SAMSUNG: Clean-up DMA " Seungwhan Youn
2011-01-07  6:03     ` Jassi Brar
2011-01-07  6:02   ` [PATCH 1/4] ASoC: SAMSUNG: Remove AC97 " Jassi Brar
2011-01-07  4:57 ` [PATCH 3/4] ASoC: SAMSUNG: Move PCM specific definitions into pcm.c Seungwhan Youn
2011-01-07  6:04   ` Jassi Brar
2011-01-07  4:57 ` [PATCH 4/4] ASoC: SAMSUNG: Clean-up header includes Seungwhan Youn
2011-01-07  6:08   ` Jassi Brar [this message]
2011-01-07  7:03     ` Seungwhan Youn
2011-01-07 10:38       ` Mark Brown
2011-01-07 11:22         ` Seungwhan Youn
2011-01-10 22:26           ` [PATCH v2 " Seungwhan Youn
2011-01-11 10:51             ` Liam Girdwood
2011-01-11 11:26             ` Jassi Brar
2011-01-11 11:29             ` Mark Brown
2011-01-09 14:01 ` [PATCH 0/4] ASoC: SAMSUNG: Code clean-up suitable for current ASoC Liam Girdwood
2011-01-10 11:40   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTim+ANz=cszy4gbiWAToPFAMokKe3z9JCZVzHddm@mail.gmail.com' \
    --to=jassisinghbrar@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jassi.brar@samsung.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=sw.youn@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.