All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	tglx@linutronix.de, mingo@elte.hu, greg@kroah.com,
	akpm@linux-foundation.org, ying.huang@intel.com,
	Borislav Petkov <bp@alien8.de>,
	David Miller <davem@davemloft.net>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Jim Keniston <jkenisto@linux.vnet.ibm.com>,
	Kyungmin Park <kmpark@infradead.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [concept & "good taste" review] persistent store
Date: Thu, 16 Dec 2010 22:28:35 -0800	[thread overview]
Message-ID: <AANLkTim3OpjPysjdCLDuFgFOipmcxyr2ay5cvUAu5PHi@mail.gmail.com> (raw)
In-Reply-To: <AANLkTindPUkF7fCkdbqSstNHFjF3_7fEYh18nhQFx_AJ@mail.gmail.com>

On Thu, Dec 16, 2010 at 5:57 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> Then I hit the
>
>        /* Don't dump oopses to persistent store */
>        if (reason == KMSG_DUMP_OOPS)
>                return;
>
> and I'm like "ok, this is just stupid".
>
> The _only_ valid reason for persistent storage is for things like
> oopses that kill the machine.

Maybe I misunderstood what "KMSG_DUMP_OOPS" meant ... it
looked to me like this code is used for non-fatal OOPsen - ones
that will be logged to /var/log/messages.

You are right that the whole point of this is to save data from
fatal errors ... if I'm not doing that, then I'm happy to change
things until I achieve that goal.

-Tony

  reply	other threads:[~2010-12-17  6:28 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-13 18:16 [concept & "good taste" review] persistent store Luck, Tony
2010-12-17  1:57 ` Linus Torvalds
2010-12-17  6:28   ` Tony Luck [this message]
2010-12-17 18:09     ` Tony Luck
2010-12-17 18:19       ` James Bottomley
2010-12-17 21:38       ` Linus Torvalds
2010-12-17 23:08         ` Tony Luck
2010-12-17 23:11           ` H. Peter Anvin
2010-12-17 23:53             ` Tony Luck
2010-12-18 18:23               ` Linus Torvalds
2010-12-18 23:06                 ` Tony Luck
2010-12-19  9:17                   ` Borislav Petkov
2010-12-19 17:01                     ` Florian Mickler
2010-12-19 20:17                     ` Tony Luck
2010-12-19 20:17                       ` Tony Luck
2010-12-20  2:47                       ` Huang Ying
2010-12-20 17:19                         ` Tony Luck
2010-12-21  0:48                           ` Huang Ying
2010-12-21  5:13                             ` Tony Luck
2010-12-21  7:42                               ` Borislav Petkov
2010-12-20  7:26                       ` Borislav Petkov
2010-12-20 17:18                         ` Linus Torvalds
2010-12-20 17:18                           ` Linus Torvalds
2010-12-20 18:58                           ` Borislav Petkov
2010-12-20 21:09                             ` Tony Luck
2010-12-20 21:09                               ` Tony Luck
2010-12-20 10:46                       ` David Howells
2010-12-21  0:41                         ` Huang Ying
2010-12-21 10:10                         ` David Howells
2010-12-22  0:26                           ` Huang Ying
2010-12-22  0:53                             ` david
2010-12-22  7:34                               ` Tony Luck
2010-12-22  0:32                           ` David Howells
2010-12-22  0:32                             ` David Howells
2010-12-22  0:43                             ` Huang Ying
2010-12-20 10:49                     ` David Howells
2010-12-20 16:52                       ` Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTim3OpjPysjdCLDuFgFOipmcxyr2ay5cvUAu5PHi@mail.gmail.com \
    --to=tony.luck@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bp@alien8.de \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=greg@kroah.com \
    --cc=hpa@zytor.com \
    --cc=jkenisto@linux.vnet.ibm.com \
    --cc=kmpark@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.