From: Brian Cavagnolo <brian@cozybit.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/7] mwl8k: choose proper firmware image as directed by user
Date: Wed, 3 Nov 2010 17:19:39 -0700 [thread overview]
Message-ID: <AANLkTim3x5dNtdKuyQBqB5edtb+REuc90CVEAoyyLgRP@mail.gmail.com> (raw)
In-Reply-To: <20101102083035.GM1733@mail.wantstofly.org>
On Tue, Nov 2, 2010 at 1:30 AM, Lennert Buytenhek
<buytenh@wantstofly.org> wrote:
> On Mon, Nov 01, 2010 at 05:55:50PM -0700, Brian Cavagnolo wrote:
>
>> The mwl8k can operate in AP or STA mode, depending on the
>> firmware image that is loaded. Allow the user to specify
>> the desired firmware image at module load time.
>
> Strong NAK on selecting firmware image type with a module parameter,
> that's so wrong it's not even funny.
>
> Just use the STA image before ->add_interface() has been called if
> it is available.
The intention here is to save users who wish to only operate in AP
mode from sustaining an unnecessary firmware re-load. Can you
elaborate on why it is unacceptable to achieve this with a module
parameter? Perhaps just calling it ap_mode instead of want_ap_fw
makes more sense?
> And please switch to async firmware loading while you're at it.
Okay.
>> Also, the firmware image can be swapped to meet the user's
>> add_interface request. For example, suppose the STA
>> firmware is loaded, no STA interface has been added, and the
>> user adds an AP interface. In this case, the AP firmware
>> will be loaded to meet the request.
>>
>> Based on a patch from Pradeep Nemavat <pnemavat@marvell.com>
>
> Which was suggested by Lennert Buytenhek -- please give credit where
> it is due.
>
My apologies. Understood.
next prev parent reply other threads:[~2010-11-04 0:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 0:55 [PATCH 1/7] mwl8k: add firmware files for 8366 Brian Cavagnolo
2010-11-02 0:55 ` [PATCH 2/7] mwl8k: rf_tx_power cmd deprecated for AP firmware Brian Cavagnolo
2010-11-02 8:32 ` Lennert Buytenhek
2010-11-02 0:55 ` [PATCH 3/7] mwl8k: allow for padding in AP transmit descriptor Brian Cavagnolo
2010-11-02 8:53 ` Lennert Buytenhek
2010-11-02 0:55 ` [PATCH 4/7] mwl8k: force AP mode to use non-AMPDU frames Brian Cavagnolo
2010-11-02 8:57 ` Lennert Buytenhek
2010-11-02 0:55 ` [PATCH 5/7] mwl8k: factor out firmware loading and hw init code Brian Cavagnolo
2010-11-02 9:01 ` Lennert Buytenhek
2010-11-02 0:55 ` [PATCH 6/7] mwl8k: choose proper firmware image as directed by user Brian Cavagnolo
2010-11-02 8:30 ` Lennert Buytenhek
2010-11-04 0:19 ` Brian Cavagnolo [this message]
2010-11-02 0:55 ` [PATCH 7/7] mac80211: unset SDATA_STATE_OFFCHANNEL when cancelling a scan Brian Cavagnolo
2010-11-02 8:31 ` Lennert Buytenhek
2010-11-04 0:20 ` Brian Cavagnolo
2010-11-02 8:22 ` [PATCH 1/7] mwl8k: add firmware files for 8366 Lennert Buytenhek
2010-11-04 0:19 ` Brian Cavagnolo
2010-11-04 15:36 ` Johannes Berg
2010-11-04 20:53 ` Brian Cavagnolo
2010-11-05 0:15 ` Lennert Buytenhek
2010-11-13 1:23 ` [PATCH V2 0/6] mwl8k: add initial support for AP firmware on 8366 Brian Cavagnolo
2010-11-13 1:23 ` [PATCH V2 1/7] mwl8k: revert unnecessary modification of tx descriptor Brian Cavagnolo
2010-11-13 1:23 ` [PATCH V2 2/7] mwl8k: rf_tx_power cmd not supported by AP firmware APIv1 Brian Cavagnolo
2010-11-13 1:23 ` [PATCH V2 3/7] mwl8k: factor out firmware loading and hw init code Brian Cavagnolo
2010-11-13 1:25 ` Brian Cavagnolo
2010-11-13 1:23 ` [PATCH V2 4/7] mwl8k: choose proper firmware image as directed by user Brian Cavagnolo
2010-11-13 1:25 ` Brian Cavagnolo
2010-11-13 1:23 ` [PATCH V2 5/7] mwl8k: add API version checking for AP firmware Brian Cavagnolo
2010-11-13 1:23 ` [PATCH V2 6/7] mwl8k: make initial firmware load asynchronous Brian Cavagnolo
2010-11-13 1:23 ` [PATCH V2 7/7] mwl8k: use const struct fw pointers throughout Brian Cavagnolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim3x5dNtdKuyQBqB5edtb+REuc90CVEAoyyLgRP@mail.gmail.com \
--to=brian@cozybit.com \
--cc=buytenh@wantstofly.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.